d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent foot-shooting in advance: Put the MATCH() macro's value

Browse Source 
in parentheses.  The ?: operator has a remarkably low precedence, so
expressions like (MATCH(foo) && bar) would have an unexpected meaning
w/o the parentheses around MATCH().

Tested with:	md5(1)
This commit is contained in:
Yaroslav Tykhiy 2007-04-02 06:47:48 +00:00
parent ff7499570c
commit b1b46280cb
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.bin/sed/process.c
View File

@ -264,9 +264,9 @@ new: if (!nflag && !pd)
* TRUE if the address passed matches the current program state * TRUE if the address passed matches the current program state
* (lastline, linenumber, ps). * (lastline, linenumber, ps).
*/ */
#define MATCH(a) \ #define MATCH(a) \
(a)->type == AT_RE ? regexec_e((a)->u.r, ps, 0, 1, psl) : \ ((a)->type == AT_RE ? regexec_e((a)->u.r, ps, 0, 1, psl) : \
(a)->type == AT_LINE ? linenum == (a)->u.l : lastline() (a)->type == AT_LINE ? linenum == (a)->u.l : lastline())
/* /*
* Return TRUE if the command applies to the current line. Sets the inrange * Return TRUE if the command applies to the current line. Sets the inrange