d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fuse(4): skip the Write.append test unless vfs.fuse.sync_resize==0

Browse Source 
Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Alan Somers 2019-03-14 14:59:59 +00:00
parent 0e125f5ff8
commit b6e5e8cf5b
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/sys/fs/fuse/write.cc
View File

@ -65,6 +65,18 @@ void expect_release(uint64_t ino, ProcessMockerT r)
).WillRepeatedly(Invoke(r));
}
void require_sync_resize_0() {
const char *sync_resize_node = "vfs.fuse.sync_resize";
int val = 0;
size_t size = sizeof(val);
ASSERT_EQ(0, sysctlbyname(sync_resize_node, &val, &size, NULL, 0))
<< strerror(errno);
if (val != 0)
FAIL() << "vfs.fuse.sync_resize must be set to 0 for this test."
" That sysctl will probably be removed soon.";
}
};
class AioWrite: public Write {
@ -87,7 +99,6 @@ class WriteThrough: public Write {
virtual void SetUp() {
const char *cache_mode_node = "vfs.fuse.data_cache_mode";
const char *sync_resize_node = "vfs.fuse.sync_resize";
int val = 0;
size_t size = sizeof(val);
@ -98,12 +109,6 @@ virtual void SetUp() {
FAIL() << "vfs.fuse.data_cache_mode must be set to 1 "
"(writethrough) for this test";
ASSERT_EQ(0, sysctlbyname(sync_resize_node, &val, &size, NULL, 0))
<< strerror(errno);
if (val != 0)
FAIL() << "vfs.fuse.sync_resize must be set to 0 for this test."
" That sysctl will probably be removed soon.";
FuseTest::SetUp();
}
@ -183,6 +188,8 @@ TEST_F(Write, append)
uint64_t initial_offset = m_maxbcachebuf;
int fd;
require_sync_resize_0();
expect_lookup(RELPATH, ino);
expect_open(ino, 0, 1);
expect_getattr(ino, initial_offset);