d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hyperv/hn: Use IFQ_DRV_PREPEND instead of IF_PREPEND

Browse Source 
IF_PREPEND promises out-of-order packet sending when the TX desc list
is depleted. It was overlooked and copied blindly when the transmission
path was partially rewritten.

MFC after:	1 week
Sponsored by:	Microsoft OSTC
Differential Revision:	https://reviews.freebsd.org/D5386
This commit is contained in:
Sepherosa Ziehau 2016-02-23 09:25:20 +00:00
parent 70907712be
commit b87683cb78
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
View File

@ -998,14 +998,14 @@ hn_start_locked(struct hn_tx_ring *txr, int len)
* dispatch this packet sending (and sending of any * dispatch this packet sending (and sending of any
* following up packets) to tx taskqueue. * following up packets) to tx taskqueue.
*/ */
IF_PREPEND(&ifp->if_snd, m_head); IFQ_DRV_PREPEND(&ifp->if_snd, m_head);
return 1; return 1;
} }
txd = hn_txdesc_get(txr); txd = hn_txdesc_get(txr);
if (txd == NULL) { if (txd == NULL) {
txr->hn_no_txdescs++; txr->hn_no_txdescs++;
IF_PREPEND(&ifp->if_snd, m_head); IFQ_DRV_PREPEND(&ifp->if_snd, m_head);
atomic_set_int(&ifp->if_drv_flags, IFF_DRV_OACTIVE); atomic_set_int(&ifp->if_drv_flags, IFF_DRV_OACTIVE);
break; break;
} }
@ -1019,7 +1019,7 @@ hn_start_locked(struct hn_tx_ring *txr, int len)
error = hn_send_pkt(ifp, device_ctx, txr, txd); error = hn_send_pkt(ifp, device_ctx, txr, txd);
if (__predict_false(error)) { if (__predict_false(error)) {
/* txd is freed, but m_head is not */ /* txd is freed, but m_head is not */
IF_PREPEND(&ifp->if_snd, m_head); IFQ_DRV_PREPEND(&ifp->if_snd, m_head);
atomic_set_int(&ifp->if_drv_flags, IFF_DRV_OACTIVE); atomic_set_int(&ifp->if_drv_flags, IFF_DRV_OACTIVE);
break; break;
} }