d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unneeded call to revoke() inside openpty().

Browse Source 
As discussed on the commits list, there is no need to call revoke()
inside openpty(). On RELENG_6 and RELENG_7 unlockpt() will call
revoke(). On HEAD we create pseudo-terminals on demand, so there is no
need to revoke the slave device node.

This change should never be MFC'd, because the implementation we have in
RELENG_6 and RELENG_7 should work flawlessly with older versions of
libc.

Discussed with:	jhb
MFC after:	never
This commit is contained in:
Ed Schouten 2008-10-28 06:00:13 +00:00
parent 0c3d9d1f6b
commit b8cbf1a36a
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/libutil/pty.c
View File

@ -47,7 +47,6 @@ static char sccsid[] = "@(#)pty.c 8.3 (Berkeley) 5/16/94";
#include <stdlib.h>
#include <string.h>
#include <termios.h>
#include <unistd.h>
int
openpty(int *amaster, int *aslave, char *name, struct termios *termp,
@ -70,9 +69,6 @@ openpty(int *amaster, int *aslave, char *name, struct termios *termp,
if (slavename == NULL)
goto bad;
if (revoke(slavename) == -1)
goto bad;
slave = open(slavename, O_RDWR);
if (slave == -1)
goto bad;