d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use address of specific union member instead of whole union address to

Browse Source 
fix PVS-Studio warnings.

MFC after:	1 week
This commit is contained in:
Andrey V. Elsukov 2017-04-14 11:41:09 +00:00
parent 1ca7c3b815
commit ba3e1361b0
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/netpfil/ipfw/ip_fw_table_algo.c
View File

@ -526,7 +526,8 @@ ta_dump_radix_tentry(void *ta_state, struct table_info *ti, void *e,
#ifdef INET6
} else {
xn = (struct radix_addr_xentry *)e;
memcpy(&tent->k, &xn->addr6.sin6_addr, sizeof(struct in6_addr));
memcpy(&tent->k.addr6, &xn->addr6.sin6_addr,
sizeof(struct in6_addr));
tent->masklen = xn->masklen;
tent->subtype = AF_INET6;
tent->v.kidx = xn->value;
@ -1381,7 +1382,7 @@ ta_dump_chash_tentry(void *ta_state, struct table_info *ti, void *e,
tent->v.kidx = ent->value;
#ifdef INET6
} else {
memcpy(&tent->k, &ent->a.a6, sizeof(struct in6_addr));
memcpy(&tent->k.addr6, &ent->a.a6, sizeof(struct in6_addr));
tent->masklen = cfg->mask6;
tent->subtype = AF_INET6;
tent->v.kidx = ent->value;
@ -3983,7 +3984,8 @@ ta_dump_kfib_tentry_int(struct sockaddr *paddr, struct sockaddr *pmask,
if (paddr->sa_family == AF_INET6) {
addr6 = (struct sockaddr_in6 *)paddr;
mask6 = (struct sockaddr_in6 *)pmask;
memcpy(&tent->k, &addr6->sin6_addr, sizeof(struct in6_addr));
memcpy(&tent->k.addr6, &addr6->sin6_addr,
sizeof(struct in6_addr));
len = 128;
if (mask6 != NULL)
len = contigmask((uint8_t *)&mask6->sin6_addr, 128);