d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MFV r297506: 6738 zfs send stream padding needs documentation

Browse Source 
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Paul Dagnelie <pcd@delphix.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Author: Eli Rosenthal <eli.rosenthal@delphix.com>

illumos/illumos-gate@c20404ff77
This commit is contained in:
Alexander Motin 2016-04-02 08:36:24 +00:00
commit baf8ceac9e
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_send.c
View File

@ -107,6 +107,19 @@ dump_bytes(dmu_sendarg_t *dsp, void *buf, int len)
dsl_dataset_t *ds = dmu_objset_ds(dsp->dsa_os);
struct uio auio;
struct iovec aiov;
/*
* The code does not rely on this (len being a multiple of 8). We keep
* this assertion because of the corresponding assertion in
* receive_read(). Keeping this assertion ensures that we do not
* inadvertently break backwards compatibility (causing the assertion
* in receive_read() to trigger on old software).
*
* Removing the assertions could be rolled into a new feature that uses
* data that isn't 8-byte aligned; if the assertions were removed, a
* feature flag would have to be added.
*/
ASSERT0(len % 8);
aiov.iov_base = buf;
@ -1824,7 +1837,10 @@ receive_read(struct receive_arg *ra, int len, void *buf)
{
int done = 0;
/* some things will require 8-byte alignment, so everything must */
/*
* The code doesn't rely on this (lengths being multiples of 8). See
* comment in dump_bytes.
*/
ASSERT0(len % 8);
while (done < len) {