d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Put parenthesis around sizeof args.

Browse Source 
Allow for host names up to MAXHOSTNAMELEN - 1 in length.

Prompted by: bde
This commit is contained in:
Brian Somers 1999-04-07 08:26:50 +00:00
parent 10b66c2f42
commit bc19c8517d
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/libutil/realhostname.c
View File

@ -23,7 +23,7 @@
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE. * SUCH DAMAGE.
* *
* $Id:$ * $Id: realhostname.c,v 1.1 1999/04/06 23:02:35 brian Exp $
*/ */
#include <sys/param.h> #include <sys/param.h>
@ -45,13 +45,13 @@ realhostname(char *host, size_t hsize, const struct in_addr *ip)
struct hostent *hp; struct hostent *hp;
result = HOSTNAME_INVALIDADDR; result = HOSTNAME_INVALIDADDR;
hp = gethostbyaddr((char *)ip, sizeof *ip, AF_INET); hp = gethostbyaddr((char *)ip, sizeof(*ip), AF_INET);
if (hp != NULL && strlen(hp->h_name) <= hsize) { if (hp != NULL && strlen(hp->h_name) <= hsize) {
char lookup[MAXHOSTNAMELEN + 1]; char lookup[MAXHOSTNAMELEN];
strncpy(lookup, hp->h_name, sizeof lookup - 1); strncpy(lookup, hp->h_name, sizeof(lookup) - 1);
lookup[sizeof lookup - 1] = '\0'; lookup[sizeof(lookup) - 1] = '\0';
hp = gethostbyname(lookup); hp = gethostbyname(lookup);
if (hp == NULL) if (hp == NULL)
result = HOSTNAME_INVALIDNAME; result = HOSTNAME_INVALIDNAME;
@ -60,7 +60,7 @@ realhostname(char *host, size_t hsize, const struct in_addr *ip)
result = HOSTNAME_INCORRECTNAME; result = HOSTNAME_INCORRECTNAME;
break; break;
} }
if (!memcmp(*hp->h_addr_list, ip, sizeof *ip)) { if (!memcmp(*hp->h_addr_list, ip, sizeof(*ip))) {
strncpy(host, lookup, hsize); strncpy(host, lookup, hsize);
return HOSTNAME_FOUND; return HOSTNAME_FOUND;
} }