d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix mips build breakage introduced in r216375: atomic_store_int doesn't exists

Browse Source 
1) 32-bit assignment are expected to always be atomic.
2) Release/acquire memory barrier semantics doesn't seem to be needed here.
So a simple assignment can be used.

Remove unused port_set_counter() while here, it also used to mis-use
atomic_set_int().

Reported by:	jhb
Pointyhat to:	avg
MFC after:	3 weeks
This commit is contained in:
Andriy Gapon 2010-12-13 14:30:35 +00:00
parent 7ef1629be1
commit bc8022ea4a
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/mips/rmi/dev/xlr/rge.c
View File

@ -170,10 +170,8 @@ extern uint32_t cpu_ltop_map[32];
static int port_counters[4][8] __aligned(XLR_CACHELINE_SIZE);
#define port_inc_counter(port, counter) atomic_add_int(&port_counters[port][(counter)], 1)
#define port_set_counter(port, counter, value) atomic_store_int(&port_counters[port][(counter)], (value))
#else
#define port_inc_counter(port, counter) /* Nothing */
#define port_set_counter(port, counter, value) /* Nothing */
#endif
int xlr_rge_tx_prepend[MAXCPU];
@ -2281,7 +2279,7 @@ rmi_xlr_mac_open(struct rge_softc *sc)
mtx_unlock_spin(&priv->lock);
for (i = 0; i < 8; i++) {
atomic_store_int(&(priv->frin_to_be_sent[i]), 0);
priv->frin_to_be_sent[i] = 0;
}
return 0;