d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

kgssapi: Don't leak memory in error cases

Browse Source 
Reported by:	Coverity
CIDs:		1007046, 1007047, 1007048
Sponsored by:	EMC / Isilon Storage Division
This commit is contained in:
Conrad Meyer 2016-04-26 18:11:45 +00:00
parent 561e173f7e
commit be0edef163
1 changed files with 9 additions and 3 deletions

12
sys/kgssapi/gssd_prot.c

@ -101,8 +101,10 @@ xdr_gss_OID(XDR *xdrs, gss_OID *oidp)
} else {
oid = mem_alloc(sizeof(gss_OID_desc));
memset(oid, 0, sizeof(*oid));
if (!xdr_gss_OID_desc(xdrs, oid))
if (!xdr_gss_OID_desc(xdrs, oid)) {
mem_free(oid, sizeof(gss_OID_desc));
return (FALSE);
}
*oidp = oid;
}
break;
@ -164,8 +166,10 @@ xdr_gss_OID_set(XDR *xdrs, gss_OID_set *setp)
} else {
set = mem_alloc(sizeof(gss_OID_set_desc));
memset(set, 0, sizeof(*set));
if (!xdr_gss_OID_set_desc(xdrs, set))
if (!xdr_gss_OID_set_desc(xdrs, set)) {
mem_free(set, sizeof(gss_OID_set_desc));
return (FALSE);
}
*setp = set;
}
break;
@ -224,8 +228,10 @@ xdr_gss_channel_bindings_t(XDR *xdrs, gss_channel_bindings_t *chp)
|| !xdr_gss_buffer_desc(xdrs,
&ch->acceptor_address)
|| !xdr_gss_buffer_desc(xdrs,
&ch->application_data))
&ch->application_data)) {
mem_free(ch, sizeof(*ch));
return (FALSE);
}
*chp = ch;
}
break;