d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

iflib: fix typo bug introduced by r367093

Browse Source 
Code was supposed to call callout_reset_sbt_on() rather than
callout_reset_sbt(). This resulted into passing a "cpu" value
to a "flag" argument. A recipe for subtle errors.

PR:	248652
Reported by:	sg@efficientip.com
MFC with: r367093
This commit is contained in:
Vincenzo Maffione 2020-10-28 21:06:17 +00:00
parent d9999ae9ca
commit be7a6b3d84
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/net/iflib.c
View File

@ -1066,9 +1066,10 @@ iflib_netmap_txsync(struct netmap_kring *kring, int flags)
if (!(ctx->ifc_flags & IFC_NETMAP_TX_IRQ))
if (kring->nr_hwtail != nm_prev(kring->nr_hwcur, lim)) {
callout_reset_sbt(&txq->ift_netmap_timer,
callout_reset_sbt_on(&txq->ift_netmap_timer,
NETMAP_TX_TIMER_US * SBT_1US, SBT_1US,
iflib_netmap_timer, txq, txq->ift_netmap_timer.c_cpu);
iflib_netmap_timer, txq,
txq->ift_netmap_timer.c_cpu, 0);
}
return (0);
}