d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Being able to access a path do not necessarily mean we have access

Browse Source 
to a directory. So instead of doing this, we just call mkdir(2)
directly and test if the returned value is 0 or errno is EISDIR.

Reported by:	Coverity
CID:		1238925
MFC after:	1 week
This commit is contained in:
Xin LI 2014-09-25 22:22:43 +00:00
parent dde47d8bbc
commit be930504be
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
contrib/hyperv/tools/hv_kvp_daemon.c
View File

@ -284,12 +284,10 @@ kvp_file_init(void)
int i;
int alloc_unit = sizeof(struct kvp_record) * ENTRIES_PER_BLOCK;
if (access("/var/db/hyperv/pool", F_OK)) {
if (mkdir("/var/db/hyperv/pool",
S_IRUSR | S_IWUSR | S_IROTH)) {
KVP_LOG(LOG_ERR, " Failed to create /var/db/hyperv/pool\n");
exit(EXIT_FAILURE);
}
if (mkdir("/var/db/hyperv/pool", S_IRUSR | S_IWUSR | S_IROTH) < 0 &&
errno != EISDIR) {
KVP_LOG(LOG_ERR, " Failed to create /var/db/hyperv/pool\n");
exit(EXIT_FAILURE);
}
for (i = 0; i < HV_KVP_POOL_COUNT; i++)