d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Return EPERM from lookup() if cn_nameiop is DELETE or RENAME and

Browse Source 
the last component of the path name is "..".  This keeps VOP_LOOKUP()
from locking vnodes in reverse order.

Tested by:	Denis Shaposhnikov <dsh AT vlink DOT ru>
MFC after:	3 days
This commit is contained in:
Don Lewis 2006-01-21 19:57:56 +00:00
parent 04fe37f68e
commit bea7a8d75c
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
sys/kern/vfs_lookup.c
View File

@ -467,18 +467,25 @@ lookup(ndp)
}
/*
* Handle "..": two special cases.
* 1. If at root directory (e.g. after chroot)
* Handle "..": four special cases.
* 1. Return an error if this is the last component of
* the name and the operation is DELETE or RENAME.
* 2. If at root directory (e.g. after chroot)
* or at absolute root directory
* then ignore it so can't get out.
* 2. If this vnode is the root of a mounted
* 3. If this vnode is the root of a mounted
* filesystem, then replace it with the
* vnode which was mounted on so we take the
* .. in the other filesystem.
* 3. If the vnode is the top directory of
* 4. If the vnode is the top directory of
* the jail or chroot, don't let them out.
*/
if (cnp->cn_flags & ISDOTDOT) {
if ((cnp->cn_flags & ISLASTCN) != 0 &&
(cnp->cn_nameiop == DELETE || cnp->cn_nameiop == RENAME)) {
error = EPERM;
goto bad;
}
for (;;) {
if (dp == ndp->ni_rootdir ||
dp == ndp->ni_topdir ||