d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sockets: assert that any protocol with PR_RIGHTS has dom_dispose()

Browse Source 
Through the entire history only PF_UNIX has this feature.

Reviewed by:		markj
Differential revision:	https://reviews.freebsd.org/D35123
This commit is contained in:
Gleb Smirnoff 2022-05-09 10:42:48 -07:00
parent 2400c536b4
commit c17418a0ba
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/kern/uipc_socket.c
View File

@ -1195,8 +1195,10 @@ sofree(struct socket *so)
so->so_dtor(so);
VNET_SO_ASSERT(so);
if (pr->pr_flags & PR_RIGHTS && pr->pr_domain->dom_dispose != NULL)
if (pr->pr_flags & PR_RIGHTS) {
MPASS(pr->pr_domain->dom_dispose != NULL);
(*pr->pr_domain->dom_dispose)(so);
}
if (pr->pr_usrreqs->pru_detach != NULL)
(*pr->pr_usrreqs->pru_detach)(so);
@ -2989,8 +2991,10 @@ sorflush(struct socket *so)
* any unsafe routines (that rely on locks being initialized) on aso.
*/
pr = so->so_proto;
if (pr->pr_flags & PR_RIGHTS && pr->pr_domain->dom_dispose != NULL)
if (pr->pr_flags & PR_RIGHTS) {
MPASS(pr->pr_domain->dom_dispose != NULL);
(*pr->pr_domain->dom_dispose)(&aso);
}
sbrelease_internal(&aso.so_rcv, so);
}