d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reverse misordered unlock and lock in at_control for netatalk phase I

Browse Source 
addresses.

Submitted by:	Russell Cattelan <cattelan at thebarn.com>
Approved by:	re (kib)
This commit is contained in:
Robert Watson 2009-08-12 10:44:13 +00:00
parent d19d55a76f
commit c1aee61218
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/netatalk/at_control.c
View File

@ -276,7 +276,7 @@ at_control(struct socket *so, u_long cmd, caddr_t data, struct ifnet *ifp,
* If the request is specifying phase 1, then * If the request is specifying phase 1, then
* only look at a phase one address * only look at a phase one address
*/ */
AT_IFADDR_RUNLOCK(); AT_IFADDR_RLOCK();
for (oaa = aa; aa; aa = TAILQ_NEXT(aa, aa_link)) { for (oaa = aa; aa; aa = TAILQ_NEXT(aa, aa_link)) {
if (aa->aa_ifp == ifp && if (aa->aa_ifp == ifp &&
(aa->aa_flags & AFA_PHASE2) == 0) (aa->aa_flags & AFA_PHASE2) == 0)
@ -286,7 +286,7 @@ at_control(struct socket *so, u_long cmd, caddr_t data, struct ifnet *ifp,
ifa_free(&oaa->aa_ifa); ifa_free(&oaa->aa_ifa);
if (aa != NULL && oaa != aa) if (aa != NULL && oaa != aa)
ifa_ref(&aa->aa_ifa); ifa_ref(&aa->aa_ifa);
AT_IFADDR_RLOCK(); AT_IFADDR_RUNLOCK();
} else { } else {
struct at_ifaddr *oaa; struct at_ifaddr *oaa;