d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Redo the previous fix by setting the UMA_ZONE_ZINIT bit in the syncache

Browse Source 
zone, eliminating the need to call bzero() after each syncache entry
allocation.

Suggested by:	glebius
Reviewed by:	andre
MFC after:	3 days
This commit is contained in:
Qing Li 2006-02-08 23:32:57 +00:00
parent d9a7dc858a
commit c1fd993af9
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/netinet/tcp_syncache.c
View File

@ -255,7 +255,8 @@ syncache_init(void)
* older one. * older one.
*/ */
tcp_syncache.zone = uma_zcreate("syncache", sizeof(struct syncache), tcp_syncache.zone = uma_zcreate("syncache", sizeof(struct syncache),
NULL, NULL, NULL, NULL, UMA_ALIGN_PTR, UMA_ZONE_NOFREE); NULL, NULL, NULL, NULL, UMA_ALIGN_PTR,
UMA_ZONE_NOFREE | UMA_ZONE_ZINIT);
uma_zone_set_max(tcp_syncache.zone, tcp_syncache.cache_limit); uma_zone_set_max(tcp_syncache.zone, tcp_syncache.cache_limit);
tcp_syncache.cache_limit -= 1; tcp_syncache.cache_limit -= 1;
} }
@ -915,7 +916,6 @@ syncache_add(inc, to, th, sop, m)
/* /*
* Fill in the syncache values. * Fill in the syncache values.
*/ */
bzero(sc, sizeof(*sc));
sc->sc_tp = tp; sc->sc_tp = tp;
sc->sc_inp_gencnt = tp->t_inpcb->inp_gencnt; sc->sc_inp_gencnt = tp->t_inpcb->inp_gencnt;
sc->sc_ipopts = ipopts; sc->sc_ipopts = ipopts;
@ -1386,7 +1386,6 @@ syncookie_lookup(inc, th, so)
* Fill in the syncache values. * Fill in the syncache values.
* XXX duplicate code from syncache_add * XXX duplicate code from syncache_add
*/ */
bzero(sc, sizeof(*sc));
sc->sc_ipopts = NULL; sc->sc_ipopts = NULL;
sc->sc_inc.inc_fport = inc->inc_fport; sc->sc_inc.inc_fport = inc->inc_fport;
sc->sc_inc.inc_lport = inc->inc_lport; sc->sc_inc.inc_lport = inc->inc_lport;