From c23f8d4829ce50e92b60f69b3b80e5301db476b2 Mon Sep 17 00:00:00 2001 From: Matthew Ahrens Date: Thu, 4 Oct 2018 13:10:10 -0700 Subject: [PATCH] Add codecheck make target We'd like to have tooling that verifies code style, while ignoring the commit message. For example, code does not need to be signed off in order to be tested. Current workarounds are to run `git checkstyle` and ignore the commit message errors, or to run `make cstyle shellcheck flake8 mancheck testscheck`, and make sure that list stays updated. Solution is to add a new make target, `codecheck` which does all the code checks. `checkstyle` is now simply `codecheck` + `commitcheck`. Reviewed-by: Giuseppe Di Natale Reviewed-by: George Melikov Reviewed-by: Brian Behlendorf Reviewed by: Pavel Zakharov Signed-off-by: Matthew Ahrens Closes #7985 --- Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index f2cd574a9ce1..61bf9e235090 100644 --- a/Makefile.am +++ b/Makefile.am @@ -61,7 +61,9 @@ install-data-hook: ln -fs zfs.release spl.release endif -checkstyle: cstyle shellcheck flake8 commitcheck mancheck testscheck +codecheck: cstyle shellcheck flake8 mancheck testscheck + +checkstyle: codecheck commitcheck commitcheck: @if git rev-parse --git-dir > /dev/null 2>&1; then \