d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent the usage of an uninitialized variable: do not accept

Browse Source 
StartMediaTx message before an OpnRcvChnAck message was received.

Reviewed by:	glebius
Approved by:	glebius (mentor)
MFC after:      3 days
Found with:	Coverity Prevent(tm)
CID:		498
This commit is contained in:
Paolo Pisati 2007-04-07 09:52:36 +00:00
parent f4296f2246
commit c326cd0e62
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sys/netinet/libalias/alias_skinny.c
View File

@ -309,6 +309,7 @@ AliasHandleSkinny(struct libalias *la, struct ip *pip, struct alias_link *lnk)
size_t orig_len, skinny_hdr_len = sizeof(struct skinny_header);
ConvDirection direction;
lip = -1;
tc = (struct tcphdr *)ip_next(pip);
hlen = (pip->ip_hl + tc->th_off) << 2;
tlen = ntohs(pip->ip_len);
@ -418,6 +419,16 @@ AliasHandleSkinny(struct libalias *la, struct ip *pip, struct alias_link *lnk)
#endif
return;
}
if (lip == -1) {
#ifdef LIBALIAS_DEBUG
fprintf(stderr,
"PacketAlias/Skinny: received a"
" packet,StartMediaTx Message before"
" packet,OpnRcvChnAckMsg\n"
#endif
return;
}
#ifdef LIBALIAS_DEBUG
fprintf(stderr,
"PacketAlias/Skinny: Received start media trans msg\n");