d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't use pack() for structures that is used purely for software state.

Browse Source 
Otherwise the resulting, unaligned mutex structure would trigger panic.

Submitted by:		Tom Cough <tom.couch lsi.com>
Reported/Tested by:	jhb
MFC after:		3 days
This commit is contained in:
Xin LI 2010-07-09 17:38:15 +00:00
parent d6ff3d4d13
commit c8ed14e2d8
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/dev/twa/tw_cl.h
View File

@ -74,7 +74,6 @@
#define TW_CLI_PCI_CONFIG_STATUS_OFFSET 0x6 /* status register offset */
#endif /* TW_OSL_PCI_CONFIG_ACCESSIBLE */
#pragma pack(1)
#ifdef TW_OSL_DEBUG
struct tw_cli_q_stats {
@ -206,7 +205,6 @@ struct tw_cli_ctlr_context {
#endif /* TW_OSL_DEBUG */
};
#pragma pack()
/*

4
sys/dev/twa/tw_cl_share.h
View File

@ -125,7 +125,6 @@
#define TW_CL_SEVERITY_DEBUG_STRING "DEBUG"
#pragma pack(1)
/*
* Structure, a pointer to which is used as the controller handle in
@ -190,6 +189,7 @@ struct tw_cl_req_packet {
};
#pragma pack(1)
/*
* Packet that describes an AEN/error generated by the controller,
* Common Layer, or even the OS Layer.
@ -206,6 +206,7 @@ struct tw_cl_event_packet {
TW_UINT32 event_src;
TW_UINT8 severity_str[20];
};
#pragma pack()
/* Structure to link 2 adjacent elements in a list. */
@ -215,6 +216,7 @@ struct tw_cl_link {
};
#pragma pack(1)
/* Scatter/Gather list entry with 32 bit addresses. */
struct tw_cl_sg_desc32 {
TW_UINT32 address;