From d0088cde620a442171ce4b16fd6e161a77ae0feb Mon Sep 17 00:00:00 2001 From: "Bjoern A. Zeeb" Date: Sun, 11 Apr 2010 18:47:38 +0000 Subject: [PATCH] Take a reference to make sure that the interface cannot go away during if_clone_destroy() in case parallel threads try to. PR: kern/116837 Submitted by: Mikolaj Golub (to.my.trociny gmail.com) MFC after: 10 days --- sys/net/if_clone.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sys/net/if_clone.c b/sys/net/if_clone.c index 81ac7ffbdba5..c02737bd4637 100644 --- a/sys/net/if_clone.c +++ b/sys/net/if_clone.c @@ -196,10 +196,11 @@ if_clone_createif(struct if_clone *ifc, char *name, size_t len, caddr_t params) int if_clone_destroy(const char *name) { + int err; struct if_clone *ifc; struct ifnet *ifp; - ifp = ifunit(name); + ifp = ifunit_ref(name); if (ifp == NULL) return (ENXIO); @@ -221,10 +222,14 @@ if_clone_destroy(const char *name) } #endif IF_CLONERS_UNLOCK(); - if (ifc == NULL) + if (ifc == NULL) { + if_rele(ifp); return (EINVAL); + } - return (if_clone_destroyif(ifc, ifp)); + err = if_clone_destroyif(ifc, ifp); + if_rele(ifp); + return err; } /*