d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix iommu_dvmamap_sync(): it was still operating as if the BUS_DMASYNC_*

Browse Source 
constants where flag bits (as in NetBSD), although they are consecutively
numbered in FreeBSD. This would cause unnecessary flushing in the
BUS_DMASYNC_POSTWRITE case, but was otherwise mostly harmless.
This commit is contained in:
Thomas Moestl 2003-01-21 17:08:22 +00:00
parent 72aeb19aba
commit d2ccea1588
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sys/sparc64/sparc64/iommu.c
View File

@ -996,9 +996,12 @@ iommu_dvmamap_sync(bus_dma_tag_t pt, bus_dma_tag_t dt, struct iommu_state *is,
vm_offset_t va;
vm_size_t len;
if ((op & BUS_DMASYNC_PREREAD) != 0)
switch (op) {
case BUS_DMASYNC_PREREAD:
membar(Sync);
if ((op & (BUS_DMASYNC_POSTREAD | BUS_DMASYNC_PREWRITE)) != 0) {
break;
case BUS_DMASYNC_POSTREAD:
case BUS_DMASYNC_PREWRITE:
SLIST_FOREACH(r, &map->dm_reslist, dr_link) {
va = (vm_offset_t)BDR_START(r);
len = r->dr_used;
@ -1010,10 +1013,15 @@ iommu_dvmamap_sync(bus_dma_tag_t pt, bus_dma_tag_t dt, struct iommu_state *is,
va += IO_PAGE_SIZE;
}
}
}
if ((op & BUS_DMASYNC_PREWRITE) != 0)
if (op == BUS_DMASYNC_PREWRITE)
membar(Sync);
/* BUS_DMASYNC_POSTWRITE does not require any handling. */
break;
case BUS_DMASYNC_POSTWRITE:
/* Nothing to do. */
break;
default:
panic("iommu_dvmamap_sync: bogus op %d", op);
}
}
#ifdef IOMMU_DIAG