d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gmirror: Remove a last-minute INVARIANTS breakage in r341840

Browse Source 
I mistakenly added a lock assertion to this routine at the last minute
without confirming it was held during g_mirror_create.  It isn't (it isn't
even initialized yet).  Mea culpa.  Access is exclusive in both callers,
just not always by that particular lock.

Reported by:	lwhsu
X-MFC-With:	r341840, r341674
This commit is contained in:
Conrad Meyer 2018-12-12 18:13:56 +00:00
parent 76ed4255b5
commit d2d82bfc90
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/geom/mirror/g_mirror.c
View File

@ -3061,8 +3061,6 @@ g_mirror_reinit_from_metadata(struct g_mirror_softc *sc,
const struct g_mirror_metadata *md)
{
sx_assert(&sc->sc_lock, SX_XLOCKED);
sc->sc_genid = md->md_genid;
sc->sc_syncid = md->md_syncid;