d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use proper failure path rather than just returning.

Browse Source 
CID: 1199354, 1006894, 1006893, 1006892
This commit is contained in:
Warner Losh 2017-12-28 05:33:24 +00:00
parent 1987e300d0
commit d79dc9b482
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
usr.sbin/cpucontrol/intel.c
View File

@ -261,7 +261,7 @@ intel_update(const char *dev, const char *path)
if (revision >= fw_header->revision) { if (revision >= fw_header->revision) {
WARNX(1, "skipping %s of rev %#x: up to date", WARNX(1, "skipping %s of rev %#x: up to date",
path, fw_header->revision); path, fw_header->revision);
return; goto fail;
} }
fprintf(stderr, "%s: updating cpu %s from rev %#x to rev %#x... ", fprintf(stderr, "%s: updating cpu %s from rev %#x to rev %#x... ",
path, dev, revision, fw_header->revision); path, dev, revision, fw_header->revision);

2
usr.sbin/cpucontrol/via.c
View File

@ -140,7 +140,7 @@ via_update(const char *dev, const char *path)
fd = open(path, O_RDONLY, 0); fd = open(path, O_RDONLY, 0);
if (fd < 0) { if (fd < 0) {
WARN(0, "open(%s)", path); WARN(0, "open(%s)", path);
return; goto fail;
} }
error = fstat(fd, &st); error = fstat(fd, &st);
if (error != 0) { if (error != 0) {