d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use strlcpy() instead of strncpy() when copying date and subj

Browse Source 
to ensure that these are properly NUL terminated since they
are passed to printf().

Reported by:	Coverity
CID:		974770
MFH:		1 week
This commit is contained in:
Don Lewis 2016-05-12 08:55:57 +00:00
parent 1f12a67942
commit dc77866517
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.bin/msgs/msgs.c
View File

@ -855,7 +855,7 @@ gfrsub(FILE *infile)
}
*ptr = '\0';
if (*(in = nxtfld(in)))
strncpy(date, in, sizeof date);
strlcpy(date, in, sizeof date);
else {
date[0] = '\n';
date[1] = '\0';
@ -886,7 +886,7 @@ gfrsub(FILE *infile)
if (!seensubj && strncmp(inbuf, "Subj", 4)==0) {
seensubj = YES;
frompos = ftello(infile);
strncpy(subj, nxtfld(inbuf), sizeof subj);
strlcpy(subj, nxtfld(inbuf), sizeof subj);
}
}
if (!blankline)
@ -899,7 +899,7 @@ gfrsub(FILE *infile)
/*
* for possible use with Mail
*/
strncpy(subj, "(No Subject)\n", sizeof subj);
strlcpy(subj, "(No Subject)\n", sizeof subj);
}
static char *