d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

suser() accepts a thread argument; as suser() dereferences td_ucred, a

Browse Source 
thread-local pointer, in practice that thread needs to be curthread.  If
we're running with INVARIANTS, generate a warning if not.  If we have
KDB compiled in, generate a stack trace.  This doesn't fire at all in my
local test environment, but could be irritating if it fires frequently
for someone, so there will be motivation to fix things quickly when it
does.
This commit is contained in:
Robert Watson 2004-07-22 17:05:04 +00:00
parent de592112e1
commit df04411ac4
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/kern/kern_prot.c
View File

@ -48,6 +48,7 @@ __FBSDID("$FreeBSD$");
#include <sys/param.h>
#include <sys/systm.h>
#include <sys/acct.h>
#include <sys/kdb.h>
#include <sys/kernel.h>
#include <sys/lock.h>
#include <sys/mac.h>
@ -1245,6 +1246,17 @@ int
suser(struct thread *td)
{
#ifdef INVARIANTS
if (td != curthread) {
printf("suser: thread %p (%d %s) != curthread %p (%d %s)\n",
td, td->td_proc->p_pid, td->td_proc->p_comm,
curthread, curthread->td_proc->p_pid,
curthread->td_proc->p_comm);
#ifdef KDB
kdb_backtrace();
#endif
}
#endif
return (suser_cred(td->td_ucred, 0));
}