d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpucontrol: check for the supposed firmware file type and skip

Browse Source 
non-regular entry.

do_update() skips entries with DT_DIR type.  This does not eliminate
other entries that might exist in the directory.  More, since NFS
might fill d_type with DT_UNKNOWN, dot and dotdot entries are not
skipped, then mmap(2) call failed for them when update microcode files
are located on NFS.

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
This commit is contained in:
Konstantin Belousov 2019-01-11 08:35:49 +00:00
parent 6651cf410c
commit e4e0dad424
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
usr.sbin/cpucontrol/cpucontrol.c
View File

@ -369,6 +369,8 @@ try_a_fw_image(const char *dev_path, int devfd, int fwdfd, const char *dpath,
rc = 0; rc = 0;
goto out; goto out;
} }
if (!S_ISREG(st.st_mode))
goto out;
if (st.st_size <= 0) { if (st.st_size <= 0) {
WARN(0, "%s: empty", fw_path); WARN(0, "%s: empty", fw_path);
goto out; goto out;