d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't allocate a 512 byte buffer on the stack in snplwrite. It's

Browse Source 
probably harmless in this case, since the latter is called on tty
input, which is usually a result of some system call, so we've got
plenty of stack left.  It's still nice to fix these things, though, in
case somebody ever decides this driver is a good example of something
(perhaps "what you probably shouldn't do").
This commit is contained in:
Dima Dorfman 2001-08-16 06:00:57 +00:00
parent 2f46ebcdb7
commit e692c40ce1
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
sys/dev/snp/snp.c
View File

@ -141,14 +141,17 @@ snplwrite(tp, uio, flag)
struct uio uio2;
struct snoop *snp;
int error, ilen;
char ibuf[512];
char *ibuf;
error = 0;
ibuf = NULL;
snp = tp->t_sc;
while (uio->uio_resid > 0) {
ilen = imin(sizeof(ibuf), uio->uio_resid);
ilen = imin(512, uio->uio_resid);
ibuf = malloc(ilen, M_SNP, M_WAITOK);
error = uiomove(ibuf, ilen, uio);
if (error != 0)
return (error);
break;
snp_in(snp, ibuf, ilen);
/* Hackish, but probably the least of all evils. */
iov.iov_base = ibuf;
@ -162,9 +165,13 @@ snplwrite(tp, uio, flag)
uio2.uio_procp = uio->uio_procp;
error = ttwrite(tp, &uio2, flag);
if (error != 0)
return (error);
break;
free(ibuf, M_SNP);
ibuf = NULL;
}
return (0);
if (ibuf != NULL)
free(ibuf, M_SNP);
return (error);
}
static struct tty *