From e7d9d9217c1ccc154dcf3407907ee5fa2ba7570a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dag-Erling=20Sm=C3=B8rgrav?= Date: Wed, 9 Apr 2003 18:20:51 +0000 Subject: [PATCH] Correctly detect the case where a password entry was changed while we were preparing to edit it. PR: bin/50563 --- lib/libutil/pw_util.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/libutil/pw_util.c b/lib/libutil/pw_util.c index 053ac56901f1..73d544b7a1d8 100644 --- a/lib/libutil/pw_util.c +++ b/lib/libutil/pw_util.c @@ -475,8 +475,7 @@ pw_copy(int ffd, int tfd, struct passwd *pw, struct passwd *old_pw) *q = '\0'; fpw = pw_scan(r, PWSCAN_MASTER); *q = t; - if ((old_pw && !pw_equal(fpw, old_pw)) || - (!old_pw && strcmp(fpw->pw_name, pw->pw_name))) { + if (strcmp(fpw->pw_name, pw->pw_name) != 0) { /* nope */ free(fpw); if (write(tfd, p, q - p + 1) != q - p + 1) @@ -484,6 +483,12 @@ pw_copy(int ffd, int tfd, struct passwd *pw, struct passwd *old_pw) ++q; continue; } + if (old_pw && !pw_equal(fpw, old_pw)) { + warnx("entry inconsistent"); + free(fpw); + errno = EINVAL; /* hack */ + goto err; + } free(fpw); /* it is, replace it */