d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- Denote a few places where kobj class references are manipulated without

Browse Source 
holding the appropriate lock.
- Add a comment explaining why we bump a driver's kobj class reference
  when loading a module.
This commit is contained in:
John Baldwin 2005-03-31 22:49:31 +00:00
parent 2945387fee
commit ea2b9b3e36
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/kern/kern_linker.c
View File

@ -141,13 +141,14 @@ linker_add_class(linker_class_t lc)
{
/*
* We disallow any class registration passt SI_ORDER_ANY
* of SI_SUB_KLD.
* We disallow any class registration past SI_ORDER_ANY
* of SI_SUB_KLD. We bump the reference count to keep the
* ops from being freed.
*/
if (linker_no_more_classes == 1)
return (EPERM);
kobj_class_compile((kobj_class_t) lc);
((kobj_class_t)lc)->refs++; /* prevent ops being freed */
((kobj_class_t)lc)->refs++; /* XXX: kobj_mtx */
TAILQ_INSERT_TAIL(&classes, lc, link);
return (0);
}

3
sys/kern/subr_bus.c
View File

@ -850,7 +850,7 @@ devclass_add_driver(devclass_t dc, driver_t *driver)
dl->driver = driver;
TAILQ_INSERT_TAIL(&dc->drivers, dl, link);
driver->refs++;
driver->refs++; /* XXX: kobj_mtx */
/*
* Call BUS_DRIVER_ADDED for any existing busses in this class.
@ -930,6 +930,7 @@ devclass_delete_driver(devclass_t busclass, driver_t *driver)
TAILQ_REMOVE(&busclass->drivers, dl, link);
free(dl, M_BUS);
/* XXX: kobj_mtx */
driver->refs--;
if (driver->refs == 0)
kobj_class_free((kobj_class_t) driver);