d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

UMA can return NULL not only in case when our zone is full, but

Browse Source 
also in case of generic memory shortage. In the latter case we may
not find an old entry.

Found with:	Coverity Prevent(tm)
This commit is contained in:
Gleb Smirnoff 2006-01-14 13:04:08 +00:00
parent f3d231b46b
commit ecedca7441
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/netinet/tcp_syncache.c
View File

@ -886,15 +886,21 @@ syncache_add(inc, to, th, sop, m)
* Treat this as if the cache was full; drop the oldest
* entry and insert the new one.
*/
tcpstat.tcps_sc_zonefail++;
/* NB: guarded by INP_INFO_WLOCK(&tcbinfo) */
for (i = SYNCACHE_MAXREXMTS; i >= 0; i--) {
sc = TAILQ_FIRST(&tcp_syncache.timerq[i]);
if (sc != NULL)
break;
}
if (sc == NULL) {
/* Generic memory failure. */
if (ipopts)
(void) m_free(ipopts);
return (0);
}
sc->sc_tp->ts_recent = ticks;
syncache_drop(sc, NULL);
tcpstat.tcps_sc_zonefail++;
sc = uma_zalloc(tcp_syncache.zone, M_NOWAIT);
if (sc == NULL) {
if (ipopts)