IPv6 tests: test case for scapy bpf parsing bug

PR:		239380
Reported by:	lwhsu, CI system
MFC after:	3 weeks
Sponsored by:	Netflix
This commit is contained in:
Bjoern A. Zeeb 2019-11-06 14:43:35 +00:00
parent f21d32079f
commit ed91ae7fe6
3 changed files with 183 additions and 1 deletions

View File

@ -6,11 +6,14 @@ TESTSDIR= ${TESTSBASE}/sys/netinet6
FILESDIR= ${TESTSDIR}
ATF_TESTS_SH= \
exthdr
exthdr \
scapyi386
${PACKAGE}FILES+= exthdr.py
${PACKAGE}FILES+= scapyi386.py
${PACKAGE}FILESMODE_exthdr.py= 0555
${PACKAGE}FILESMODE_scapyi386.py=0555
TESTS_SUBDIRS+= frag6

View File

@ -0,0 +1,85 @@
#!/usr/bin/env python
#-
# SPDX-License-Identifier: BSD-2-Clause
#
# Copyright (c) 2019 Netflix, Inc.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
# 1. Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# 2. Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in the
# documentation and/or other materials provided with the distribution.
#
# THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
# ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
# OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
# SUCH DAMAGE.
#
# $FreeBSD$
#
import argparse
import scapy.all as sp
import socket
import sys
def main():
parser = argparse.ArgumentParser("scapyi386.py",
description="IPv6 Ethernet Dest MAC test")
parser.add_argument('--sendif', nargs=1,
required=True,
help='The interface through which the packet will be sent')
parser.add_argument('--recvif', nargs=1,
required=True,
help='The interface on which to check for the packet')
parser.add_argument('--src', nargs=1,
required=True,
help='The source IP address')
parser.add_argument('--to', nargs=1,
required=True,
help='The destination IP address')
parser.add_argument('--debug',
required=False, action='store_true',
help='Enable test debugging')
args = parser.parse_args()
########################################################################
#
# A test case to check that IPv6 packets are sent with a proper
# (resolved) Ethernet Destination MAC address instead of the BCAST one.
# This was needed as test cases did not work properly on i386 due to a
# scapy BPF parsing bug. (See PR 239380 and duplicates).
#
bcmac = sp.Ether(dst="ff:ff:ff:ff:ff:ff").dst
data = "6" * 88
pkt = sp.Ether() / \
sp.IPv6(src=args.src[0], dst=args.to[0]) / \
sp.UDP(dport=3456, sport=6543) / \
data
sp.sendp(pkt, iface=args.sendif[0], verbose=False)
eth = pkt.getlayer(sp.Ether)
if eth is None:
print("No Ether in packet")
pkt.display()
sys.exit(1)
if eth.dst == bcmac:
print("Broadcast dMAC on packet")
eth.display()
sys.exit(1)
sys.exit(0)
if __name__ == '__main__':
main()

94
tests/sys/netinet6/scapyi386.sh Executable file
View File

@ -0,0 +1,94 @@
# $FreeBSD$
#-
# SPDX-License-Identifier: BSD-2-Clause
#
# Copyright (c) 2019 Netflix, Inc.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
# 1. Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# 2. Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in the
# documentation and/or other materials provided with the distribution.
#
# THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
# ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
# OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
# SUCH DAMAGE.
#
. $(atf_get_srcdir)/../common/vnet.subr
atf_test_case "scapyi386" "cleanup"
scapyi386_head() {
atf_set descr 'Test for correct Ethernet Destination MAC address'
atf_set require.user root
atf_set require.progs scapy
}
scapyi386_body() {
if [ "$(atf_config_get ci false)" = "true" ] && \
[ "$(uname -p)" = "i386" ]; then
atf_skip "https://bugs.freebsd.org/239380"
fi
ids=65533
id=`printf "%x" ${ids}`
if [ $$ -gt 65535 ]; then
xl=`printf "%x" $(($$ - 65535))`
yl="1"
else
xl=`printf "%x" $$`
yl=""
fi
vnet_init
ip6a="2001:db8:6666:0000:${yl}:${id}:1:${xl}"
ip6b="2001:db8:6666:0000:${yl}:${id}:2:${xl}"
epair=$(vnet_mkepair)
ifconfig ${epair}a up
ifconfig ${epair}a inet6 ${ip6a}/64
jname="v6t-${id}-${yl}-${xl}"
vnet_mkjail ${jname} ${epair}b
jexec ${jname} ifconfig ${epair}b up
jexec ${jname} ifconfig ${epair}b inet6 ${ip6b}/64
# Let IPv6 ND do its thing.
#ping6 -q -c 1 ff02::1%${epair}a
#ping6 -q -c 1 ${ip6b}
sleep 3
pyname=$(atf_get ident)
pyname=${pyname%*_[0-9]}
atf_check -s exit:0 $(atf_get_srcdir)/${pyname}.py \
--sendif ${epair}a --recvif ${epair}a \
--src ${ip6a} --to ${ip6b}
}
scapyi386_cleanup() {
vnet_cleanup
}
atf_init_test_cases()
{
atf_add_test_case "scapyi386"
}
# end