d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cache: clean up atomic ops on numneg and numcache

Browse Source 
- use subtract instead of adding -1
- drop the useless _rel fence

Note this should be converted to a scalable scheme.
This commit is contained in:
Mateusz Guzik 2020-09-23 10:42:41 +00:00
parent 867ae3c38d
commit efeec5f0c6
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/kern/vfs_cache.c
View File

@ -841,7 +841,7 @@ cache_negative_insert(struct namecache *ncp)
mtx_lock(&neglist->nl_lock);
TAILQ_INSERT_TAIL(&neglist->nl_list, ncp, nc_dst);
mtx_unlock(&neglist->nl_lock);
atomic_add_rel_long(&numneg, 1);
atomic_add_long(&numneg, 1);
}
static void
@ -887,7 +887,7 @@ cache_negative_remove(struct namecache *ncp)
mtx_unlock(&neglist->nl_lock);
if (hot_locked)
mtx_unlock(&ncneg_hot.nl_lock);
atomic_subtract_rel_long(&numneg, 1);
atomic_subtract_long(&numneg, 1);
}
static void
@ -1030,7 +1030,7 @@ cache_zap_locked(struct namecache *ncp)
counter_u64_add(numcachehv, -1);
}
}
atomic_subtract_rel_long(&numcache, 1);
atomic_subtract_long(&numcache, 1);
}
static void
@ -1959,7 +1959,7 @@ cache_enter_time(struct vnode *dvp, struct vnode *vp, struct componentname *cnp,
*/
lnumcache = atomic_fetchadd_long(&numcache, 1) + 1;
if (__predict_false(lnumcache >= ncsize)) {
atomic_add_long(&numcache, -1);
atomic_subtract_long(&numcache, 1);
counter_u64_add(numdrops, 1);
return;
}
@ -2125,7 +2125,7 @@ cache_enter_time(struct vnode *dvp, struct vnode *vp, struct componentname *cnp,
return;
out_unlock_free:
cache_enter_unlock(&cel);
atomic_add_long(&numcache, -1);
atomic_subtract_long(&numcache, 1);
cache_free(ncp);
return;
}