d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nis_rpcent: don't leak resultbuf from yp_first(..)/yp_next(..)

Browse Source 
If the buffer couldn't be adequately resized to accomodate an additional "\n",
it would leak resultbuf by breaking from the loop early

MFC after: 2 weeks
Reported by: Coverity
CID: 1016702
Sponsored by: EMC / Isilon Storage Division
This commit is contained in:
Enji Cooper 2016-05-22 03:05:27 +00:00
parent b70cb0694b
commit f1209420eb
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/libc/rpc/getrpcent.c
View File

@ -511,6 +511,7 @@ nis_rpcent(void *retval, void *mdata, va_list ap)
sizeof(char *)) { sizeof(char *)) {
*errnop = ERANGE; *errnop = ERANGE;
rv = NS_RETURN; rv = NS_RETURN;
free(resultbuf);
break; break;
} }
@ -520,6 +521,7 @@ nis_rpcent(void *retval, void *mdata, va_list ap)
if (aliases_size < 1) { if (aliases_size < 1) {
*errnop = ERANGE; *errnop = ERANGE;
rv = NS_RETURN; rv = NS_RETURN;
free(resultbuf);
break; break;
} }