d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix memory leak in m_collapse (CID 1843)

Browse Source 
Found by: Coverity
Submitted by: jhb
This commit is contained in:
Kip Macy 2007-04-20 05:06:02 +00:00
parent 90bf3dc7cb
commit f297a9d336
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sys/dev/cxgb/sys/uipc_mvec.c
View File

@ -258,7 +258,7 @@ _m_collapse(struct mbuf *m, int maxbufs, struct mbuf **mnew)
{
struct mbuf *m0, *lmvec[MAX_BUFS];
struct mbuf **mnext;
struct mbuf **vec = &lmvec[0];
struct mbuf **vec = lmvec;
struct mbuf *mhead = NULL;
struct mbuf_vec *mv;
int err, i, j, max, len, nhbufs;
@ -273,9 +273,9 @@ _m_collapse(struct mbuf *m, int maxbufs, struct mbuf **mnew)
}
if ((err = m_vectorize(m, maxbufs, vec, &max)) != 0)
return (err);
goto out;
if ((err = m_findmbufs(vec, max, dvec, MAX_HVEC, &nhbufs)) != 0)
return (err);
goto out;
KASSERT(max > 0, ("invalid mbuf count"));
KASSERT(nhbufs > 0, ("invalid header mbuf count"));
@ -322,7 +322,10 @@ _m_collapse(struct mbuf *m, int maxbufs, struct mbuf **mnew)
}
*mnew = mhead;
return (0);
out:
if (vec != lmvec)
free(vec, M_DEVBUF);
return (err);
}
void