d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eliminate stale comments.

Browse Source 
Eliminate a case of unnecessary page queues locking.
This commit is contained in:
Alan Cox 2009-05-10 17:05:43 +00:00
parent c299fae2cc
commit f45cc06eb1
2 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/fs/smbfs/smbfs_io.c
View File

@ -456,8 +456,6 @@ smbfs_getpages(ap)
VM_OBJECT_LOCK(object);
if (m->valid != 0) {
/* handled by vm_fault now */
/* vm_page_zero_invalid(m, TRUE); */
vm_page_lock_queues();
for (i = 0; i < npages; ++i) {
if (i != reqpage)
@ -526,8 +524,6 @@ smbfs_getpages(ap)
*/
m->valid = 0;
vm_page_set_validclean(m, 0, size - toff);
/* handled by vm_fault now */
/* vm_page_zero_invalid(m, TRUE); */
} else {
/*
* Read operation was short. If no error occured

7
sys/nfsclient/nfs_bio.c
View File

@ -138,10 +138,8 @@ nfs_getpages(struct vop_getpages_args *ap)
vm_page_t m = pages[ap->a_reqpage];
VM_OBJECT_LOCK(object);
vm_page_lock_queues();
if (m->valid != 0) {
/* handled by vm_fault now */
/* vm_page_zero_invalid(m, TRUE); */
vm_page_lock_queues();
for (i = 0; i < npages; ++i) {
if (i != ap->a_reqpage)
vm_page_free(pages[i]);
@ -150,7 +148,6 @@ nfs_getpages(struct vop_getpages_args *ap)
VM_OBJECT_UNLOCK(object);
return(0);
}
vm_page_unlock_queues();
VM_OBJECT_UNLOCK(object);
}
@ -219,8 +216,6 @@ nfs_getpages(struct vop_getpages_args *ap)
*/
m->valid = 0;
vm_page_set_validclean(m, 0, size - toff);
/* handled by vm_fault now */
/* vm_page_zero_invalid(m, TRUE); */
} else {
/*
* Read operation was short. If no error occured