d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make the rx budget a tunable

Browse Source 
This allows tuning the rx budget for special load profiles
as well as more easily testing to determine sane defaults.

Reviewed by:	sbruno
Approved by:	sbruno (mentor)
Sponsored by:	Limelight Networks
Differential Revision:	https://reviews.freebsd.org/D12445
This commit is contained in:
Stephen Hurd 2017-09-23 01:37:01 +00:00
parent 20f63282f8
commit f4d2154e0c
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/net/iflib.c
View File

@ -185,6 +185,7 @@ struct iflib_ctx {
uint16_t ifc_sysctl_ntxqs; uint16_t ifc_sysctl_ntxqs;
uint16_t ifc_sysctl_nrxqs; uint16_t ifc_sysctl_nrxqs;
uint16_t ifc_sysctl_qs_eq_override; uint16_t ifc_sysctl_qs_eq_override;
uint16_t ifc_sysctl_rx_budget;
qidx_t ifc_sysctl_ntxds[8]; qidx_t ifc_sysctl_ntxds[8];
qidx_t ifc_sysctl_nrxds[8]; qidx_t ifc_sysctl_nrxds[8];
@ -3531,6 +3532,7 @@ _task_fn_rx(void *context)
if_ctx_t ctx = rxq->ifr_ctx; if_ctx_t ctx = rxq->ifr_ctx;
bool more; bool more;
int rc; int rc;
uint16_t budget;
#ifdef IFLIB_DIAGNOSTICS #ifdef IFLIB_DIAGNOSTICS
rxq->ifr_cpu_exec_count[curcpu]++; rxq->ifr_cpu_exec_count[curcpu]++;
@ -3547,7 +3549,10 @@ _task_fn_rx(void *context)
} }
} }
#endif #endif
if (more == false || (more = iflib_rxeof(rxq, 16 /* XXX */)) == false) { budget = ctx->ifc_sysctl_rx_budget;
if (budget == 0)
budget = 16; /* XXX */
if (more == false || (more = iflib_rxeof(rxq, budget)) == false) {
if (ctx->ifc_flags & IFC_LEGACY) if (ctx->ifc_flags & IFC_LEGACY)
IFDI_INTR_ENABLE(ctx); IFDI_INTR_ENABLE(ctx);
else { else {
@ -5486,9 +5491,12 @@ iflib_add_device_sysctl_pre(if_ctx_t ctx)
SYSCTL_ADD_U16(ctx_list, oid_list, OID_AUTO, "override_qs_enable", SYSCTL_ADD_U16(ctx_list, oid_list, OID_AUTO, "override_qs_enable",
CTLFLAG_RWTUN, &ctx->ifc_sysctl_qs_eq_override, 0, CTLFLAG_RWTUN, &ctx->ifc_sysctl_qs_eq_override, 0,
"permit #txq != #rxq"); "permit #txq != #rxq");
SYSCTL_ADD_INT(ctx_list, oid_list, OID_AUTO, "disable_msix", SYSCTL_ADD_INT(ctx_list, oid_list, OID_AUTO, "disable_msix",
CTLFLAG_RWTUN, &ctx->ifc_softc_ctx.isc_disable_msix, 0, CTLFLAG_RWTUN, &ctx->ifc_softc_ctx.isc_disable_msix, 0,
"disable MSIX (default 0)"); "disable MSIX (default 0)");
SYSCTL_ADD_U16(ctx_list, oid_list, OID_AUTO, "rx_budget",
CTLFLAG_RWTUN, &ctx->ifc_sysctl_rx_budget, 0,
"set the rx budget");
/* XXX change for per-queue sizes */ /* XXX change for per-queue sizes */
SYSCTL_ADD_PROC(ctx_list, oid_list, OID_AUTO, "override_ntxds", SYSCTL_ADD_PROC(ctx_list, oid_list, OID_AUTO, "override_ntxds",