d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libctf: Don't construct pointers to out of bounds array offsets

Browse Source 
Just attempting to do the pointer arithmetic is undefined behavior.

No functional change intended.

Reported by:	Coverity
Sponsored by:	Dell EMC Isilon
This commit is contained in:
Conrad Meyer 2018-03-26 22:02:36 +00:00
parent e796cc77c5
commit f5147e312f
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cddl/contrib/opensolaris/common/ctf/ctf_lookup.c
View File

@ -59,10 +59,12 @@ isqualifier(const char *s, size_t len)
};
int h = s[len - 1] + (int)len - 105;
const struct qual *qp = &qhash[h];
const struct qual *qp;
return (h >= 0 && h < sizeof (qhash) / sizeof (qhash[0]) &&
len == qp->q_len && strncmp(qp->q_name, s, qp->q_len) == 0);
if (h < 0 || h >= sizeof (qhash) / sizeof (qhash[0]))
return (0);
qp = &qhash[h];
return (len == qp->q_len && strncmp(qp->q_name, s, qp->q_len) == 0);
}
/*