From f969a7ac4b105b989d9edcef83cc28677e186a92 Mon Sep 17 00:00:00 2001 From: Jaakko Heinonen Date: Sun, 15 Nov 2009 14:11:26 +0000 Subject: [PATCH] MFC r197956: - Catch SIGHUP to perform cleanup before exiting. - Exit if getch() returns with an error other than EINTR. Otherwise systat(1) may get stuck in an infinite loop if it doesn't receive SIGHUP when terminal closes. - Remove attempt to clear stdio error indicators. getch() doesn't use stdio, making it useless. - Remove unneeded masking of getch() return value. PR: bin/107171 Approved by: trasz (mentor) --- usr.bin/systat/keyboard.c | 11 +++++++---- usr.bin/systat/main.c | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/usr.bin/systat/keyboard.c b/usr.bin/systat/keyboard.c index 7784f5be98a3..0ab28eb2603e 100644 --- a/usr.bin/systat/keyboard.c +++ b/usr.bin/systat/keyboard.c @@ -39,8 +39,10 @@ __FBSDID("$FreeBSD$"); static const char sccsid[] = "@(#)keyboard.c 8.1 (Berkeley) 6/6/93"; #endif +#include #include #include +#include #include #include "systat.h" @@ -57,10 +59,11 @@ keyboard(void) move(CMDLINE, 0); do { refresh(); - ch = getch() & 0177; - if (ch == 0177 && ferror(stdin)) { - clearerr(stdin); - continue; + ch = getch(); + if (ch == ERR) { + if (errno == EINTR) + continue; + exit(1); } if (ch >= 'A' && ch <= 'Z') ch += 'a' - 'A'; diff --git a/usr.bin/systat/main.c b/usr.bin/systat/main.c index 28673e54e6b7..6f6b99406860 100644 --- a/usr.bin/systat/main.c +++ b/usr.bin/systat/main.c @@ -133,6 +133,7 @@ main(int argc, char **argv) exit(1); } } + signal(SIGHUP, die); signal(SIGINT, die); signal(SIGQUIT, die); signal(SIGTERM, die);