d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Plug two memory leaks: call login_close() after login_getclass(), and

Browse Source 
use free_entry() instead of free() to free a struct _entry.

PR:		28108
Submitted by:	Mark Peek <mark@whistle.com>
This commit is contained in:
Dima Dorfman 2001-06-13 05:49:37 +00:00
parent db957588c9
commit fa0590b3d3
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
usr.sbin/cron/lib/entry.c
View File

@ -262,6 +262,9 @@ load_entry(file, error_func, pw, envp)
char *username = cmd; /* temp buffer */
char *s, *group;
struct group *grp;
#ifdef LOGIN_CAP
login_cap_t *lc;
#endif
Debug(DPARS, ("load_entry()...about to parse username\n"))
ch = get_string(username, MAX_COMMAND, file, " \t");
@ -287,10 +290,11 @@ load_entry(file, error_func, pw, envp)
ecode = e_mem;
goto eof;
}
if (login_getclass(e->class) == NULL) {
if ((lc = login_getclass(e->class)) == NULL) {
ecode = e_class;
goto eof;
}
login_close(lc);
#endif
grp = NULL;
if ((s = strrchr(username, ':')) != NULL) {
@ -416,7 +420,7 @@ load_entry(file, error_func, pw, envp)
return e;
eof:
free(e);
free_entry(e);
if (ecode != e_none && error_func)
(*error_func)(ecodes[(int)ecode]);
while (ch != EOF && ch != '\n')