d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eliminate a duplicate free when deleting an interface address. This

Browse Source 
caused crashes, typically during shutdown, because the second free
referenced a mutex that had been destroyed.

Tested by:	several
Approved by:	re (scottl)
This commit is contained in:
Sam Leffler 2003-11-28 04:19:41 +00:00
parent 1510356035
commit fdc21d0d1e
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/netatalk/at_control.c
View File

@ -272,12 +272,6 @@ at_control(struct socket *so, u_long cmd, caddr_t data,
ifa0 = (struct ifaddr *)aa;
TAILQ_REMOVE(&ifp->if_addrhead, ifa0, ifa_link);
/*
* refs goes from 1->0 if no external refs. note..
* This will not free it ... looks for -1.
*/
IFAFREE(ifa0);
/*
* Now remove the at_ifaddr from the parallel structure
* as well, or we'd be in deep trouble
@ -301,11 +295,7 @@ at_control(struct socket *so, u_long cmd, caddr_t data,
}
/*
* Now dump the memory we were using.
* Decrement the reference count.
* This should probably be the last reference
* as the count will go from 0 to -1.
* (unless there is still a route referencing this)
* Now reclaim the reference.
*/
IFAFREE(ifa0);
break;