Commit Graph

4380 Commits

Author SHA1 Message Date
Mark Murray
4239cf1c01 WARNS=2 fixes.
The remaining problem of converting highly incompatible pointer types
is done by "laundering" the value through a union.

This solves the problem (in my own mind) of how a "const char *" _ever_
actually gets a value in a WARNS=2 world.
2001-09-04 17:10:57 +00:00
Ruslan Ermilov
9dd887f1a6 SECURITY.
Fixed macros for temporarily relinquishing and restoring setuid/setgid
privileges so that they never change the real user and group IDs of
the calling process.

The setre[ug]id() calls are still used in the REDUCE_PERM macro (with
the r[ug]id arguments of -1) so that the call changes the saved user
and group IDs of the process to that specified.

Also, the panic() and perr() functions had insufficient privileges to
delete the problematic file under /var/at.
2001-09-04 16:15:51 +00:00
Ruslan Ermilov
7fd5ee41e3 The implementation of -flags was broken and did not match the (poorly)
documented behavior.  Only a certain set of file flags were recognized,
and "no" flags did not match files that have corresponding flags bits
turned off.

Fix and extend the -flags functionality as follows:

: -flags [-|+]<flags>,<notflags>
:    The flags are specified using symbolic names (see chflags(1)).
:    Those with the "no" prefix (except "nodump") are said to be
:    <notflags>.  Flags in <flags> are checked to be set, and flags in
:    <notflags> are checked to be not set.  Note that this is different
:    from -perm, which only allows the user to specify mode bits that
:    are set.
:
:    If flags are preceded by a dash (``-''), this primary evaluates
:    to true if at least all of the bits in <flags> and none of the bits
:    in <notflags> are set in the file's flags bits.  If flags are pre-
:    ceded by a plus (``+''), this primary evaluates to true if any of
:    the bits in <flags> is set in the file's flags bits, or any of the
:    bits in <notflags> is not set in the file's flags bits.  Otherwise,
:    this primary evaluates to true if the bits in <flags> exactly match
:    the file's flags bits, and none of the <flags> bits match those of
:    <notflags>.

MFC after:	2 weeks
2001-09-04 16:09:01 +00:00
Ruslan Ermilov
63462b0c3a mdoc(7) police: tighten label width. 2001-09-04 10:24:52 +00:00
Robert Drehmel
c146250ee2 Use the correct blocksize when invoked with both -h and -k
options.

PR:		30275
Reviewed by:	jake
2001-09-04 09:43:31 +00:00
Andrey A. Chernov
005ee369ed File positions are off_t nowdays, not long, so:
fseek -> fseeko
    ftell -> ftello
    fseek(x, 0L, 0) -> rewind(x)

    NOTE: that fseek/ftell not works for >long offsets per POSIX:

    [EOVERFLOW] For fseek( ), the resulting file offset would be a value which
    cannot be represented correctly in an object of type long.

    [EOVERFLOW] For ftell ( ), the current file offset cannot be represented
    correctly in an object of type long.
2001-09-03 04:30:46 +00:00
Andrey A. Chernov
af8c32621d File positions are off_t nowdays, not long, so:
fseek -> fseeko
    ftell -> ftello

    NOTE: fseek/ftell not works for >long offsets per POSIX:

    [EOVERFLOW] For fseek( ), the resulting file offset would be a value which
    cannot be represented correctly in an object of type long.

    [EOVERFLOW] For ftell ( ), the current file offset cannot be represented
    correctly in an object of type long.
2001-09-02 14:40:51 +00:00
Andrey A. Chernov
8cdc766763 strtol -> strtoll (for off_t file size) 2001-09-01 23:36:40 +00:00
Andrey A. Chernov
bb8d56ce53 File positions are off_t nowdays, not long, so:
long -> off_t
  fseek -> fseeko

  NOTE: that fseek not works for >long offsets files per POSIX:

  [EOVERFLOW] For fseek( ), the resulting file offset would be a value which
  cannot be represented correctly in an object of type long.
2001-09-01 23:01:29 +00:00
Andrey A. Chernov
7a27e6571b File positions are off_t nowdays, not long, so:
strtol -> strtoll
  fseek -> fseeko

  NOTE: that fseek not works for >long offsets files per POSIX:

  [EOVERFLOW] For fseek( ), the resulting file offset would be a value which
  cannot be represented correctly in an object of type long.
2001-09-01 22:42:47 +00:00
Andrey A. Chernov
bd9dc97512 File positions are off_t nowdays, not long, so:
long -> off_t
strtol -> strtoll
fseek -> fseeko

NOTE: that fseek not works for >long offsets files per POSIX:

[EOVERFLOW] For fseek( ), the resulting file offset would be a value which
cannot be represented correctly in an object of type long.
2001-09-01 22:22:45 +00:00
Kris Kennaway
ffacb1a399 Remove some unsafe function calls from the signal handlers.
Obtained from:	OpenBSD
Reviewed by:	audit
MFC after:	2 weeks
2001-09-01 07:35:25 +00:00
Mark Peek
f57996437a Exit gracefully when a SIGHUP is received. This prevents ee from going into
an infinite spin loop when the terminal window is forcibly blown away.

PR:		29553
Reported by:	Sung N. Cho <sucho2@vt.edu>
MFC after:	1 day
2001-08-31 21:50:06 +00:00
Ruslan Ermilov
3b7e5ccc6a SECURITY: Drop `setgid kmem' bit as early as possible. 2001-08-31 16:26:37 +00:00
Ruslan Ermilov
208691fcd8 Sort predicates.
PR:		docs/30237
2001-08-31 15:48:00 +00:00
Jose M. Alcaide
afe9babfeb Add myself. 2001-08-31 11:35:18 +00:00
Adrian Chadd
27a6d44d7f Make my Grandfather famous by showing the world my middle name,
as seems to be the trend.

(Thanks Josef. :-)
2001-08-31 00:25:16 +00:00
Mike Barcroft
ad6c0a3768 Revert the previous delta and apply a better fix which corrects
a check on the final snprintf and reduces duplicated code.

Submitted by:	brian
2001-08-30 17:13:15 +00:00
Ruslan Ermilov
c0ff9709a5 Restore the `-perm +mode' feature.
Broken in the "close a PR" race, in revision 1.30.
Note that the patch in the PR did not have this bug!
2001-08-30 13:17:58 +00:00
Josef Karthauser
a56f87b1c5 Make my Dad famous by showing the world my middle name, as seems
to be the trend.
2001-08-30 13:17:26 +00:00
Mark Murray
142277ce04 Like su(1), make PAM use mandatory. Remove parts of the authentication
logic that are handled by PAM. Fix documentation to reflect this.
2001-08-30 11:27:36 +00:00
Alexander Langer
52c15acab2 Remove whitespace at end of line I happened to find during my last edit. 2001-08-30 02:32:00 +00:00
Alexander Langer
f855f63e6a Add support for proper URI encoding, using strvisx(3)'s VIS_HTTPSTYLE.
Requests through a proxy are still broken for URIs that contain
blanks, since this required a bigger rewrite of the whole function.
2001-08-30 02:30:33 +00:00
Mike Barcroft
8bd14b98d0 Add support for HTTP/1.1 name-based virtual hosts. Also, use
asprintf(3) when creating the request string, as the length of
a path is defined as unlimited by the standard and limiting the
total request to 4K is awfully arbitrary.

PR:		30054
Submitted by:	Joseph Mallett <jmallett@xMach.org>
MFC after:	8 days
2001-08-30 00:57:35 +00:00
Mike Barcroft
2b8bab2f34 o Fix some checks on snprintf(3) to prevent miscalculations.
o This fixes a memory leak that can occur on some URL's.

Pointy hat to:	brian
2001-08-29 23:51:14 +00:00
Mark Murray
6b022d0047 Manually unifdef(1) CRAY, UNICOS, hpux and sun uselsess code. 2001-08-29 14:16:17 +00:00
Joerg Wunsch
8a2ecea916 In get_string(), 0-terminate the contents of buf ``just in case'';
otherwise, if the very first fgetc() already yielded EOF, the returned
string won't get terminated at all.

MFC after:	1 day
2001-08-28 21:27:36 +00:00
Dima Dorfman
ad3a51b894 -a is not an options (sic). 2001-08-28 12:48:19 +00:00
Dima Dorfman
37a79c4533 Mention what an asterisk means in the -i display.
PR:		30069
Submitted by:	andrew@ugh.net.au
2001-08-28 12:45:47 +00:00
Matthew Dillon
bbe67657cf Remove MAP_INHERIT flag from mmaps. 2001-08-25 18:06:32 +00:00
Dima Dorfman
5222969570 ``recognized -> recognize'' where appropriate.
Obtained from:	OpenBSD
2001-08-23 21:13:31 +00:00
Brian Somers
0baa3ca450 Fix my previous snprintf() patches (which were largely no-ops).
Mostly submitted by: bde
2001-08-23 12:53:15 +00:00
Pete Fritchman
a81c08b054 Add myself.
Reviewed by:	ade
2001-08-22 23:13:55 +00:00
Mike Barcroft
666fb6724a Take maintainership of whois(1). 2001-08-21 19:24:50 +00:00
Ruslan Ermilov
65c7e9c195 Update -v documentation to match reality.
Spotted by:	bde
2001-08-21 15:59:55 +00:00
Brian Somers
08741a6f5c Revert to version 1.16 which was more correct than either of my attempts. 2001-08-21 12:54:15 +00:00
Brian Somers
ce595235cb Display a better error message when snprintf() returns < 0
Pointed out by: bde
2001-08-21 11:39:45 +00:00
Brian Somers
081f2a7ec6 Handle overflows from snprintf(), not just returns of < 0
Pointed out by: bde
2001-08-21 11:39:32 +00:00
Brian Somers
051449d576 Remove unnecessary casts.
The original (1.16) code was mostly correct, but this version is
far clearer.

Casts suggested to now be obfuscations by: bde
2001-08-21 11:24:53 +00:00
Brian Somers
cbe1d3b630 Handle snprintf() returning -1.
MFC after:	2 weeks
2001-08-20 14:46:40 +00:00
Mark Murray
b174363035 Very minor stylistic nit.
Discussed with:	ru
2001-08-20 12:46:11 +00:00
Mark Murray
012b940383 Code merge and diff reduction between this and crypto telnet.
Also remove useless AUTHENTICATION code. We have never compiled this
here, and it is doubtful that it even works without crypto.
2001-08-20 12:21:31 +00:00
Brian Somers
2aad70eb9e Don't misuse the return from snprintf.
MFC after:	2 weeks
2001-08-20 11:58:05 +00:00
Kris Kennaway
a0b13740e8 Don't overflow a buffer from command line arguments.
MFC after:	2 weeks
2001-08-20 09:43:04 +00:00
Kris Kennaway
04228e35d9 Part II of libss retirement: zap mk_cmds too.
Pointy hat to:	kris
2001-08-20 06:23:35 +00:00
Dag-Erling Smørgrav
eab5a80417 Remove a blank line that snuck in with the previous commit.
Set the default timeout to 120 seconds instead of 0 (no timeout).
2001-08-18 10:48:55 +00:00
Peter Wemm
cccce27ae3 Correct path (../crypto, not ../../crypto) 2001-08-18 03:36:26 +00:00
Dag-Erling Smørgrav
db695db7f0 Add some comments. 2001-08-17 22:22:45 +00:00
David E. O'Brien
1687fcd346 Use a build-tool to create the .mgc files.
Submitted by:	ru (partial)
Obtained from:	NetBSD (basic idea)
Reviewed by:	bde, ru
2001-08-17 17:21:38 +00:00
Max Khon
9a94731096 add an entry about myself
Reviewed by:	jdp
2001-08-17 05:59:39 +00:00
Mike Heffner
cbf16fdf21 Print a space between the function name and line number.
PR:		bin/10980
MFC after:	2 weeks
2001-08-16 16:18:14 +00:00
Mike Heffner
1ac49cd896 Add $FreeBSD$
MFC after:	2 weeks
2001-08-16 16:16:07 +00:00
Sheldon Hearn
d1050cb33c * Update author's e-mail address.
* When the author of an utility also wrote its manual page (a rarety, I
  know), it is not necessary to say that the utility "and this manual
  page" were written by the author.
2001-08-16 08:40:54 +00:00
Sheldon Hearn
b63c01391e Use the .Cm macro to mark up the modifiers of the -s flag's size argument. 2001-08-16 08:19:09 +00:00
Mike Heffner
327a1d9ddb Fix usage message, the executable is optional.
PR:		bin/29735
MFC after:	2 weeks
2001-08-15 21:25:50 +00:00
Ruslan Ermilov
bf1bf89163 Substitute ARGSTR in-place.
Forgot trailing newline in usage().
2001-08-15 15:24:08 +00:00
Ruslan Ermilov
d143364652 Fixed the usage() string.
This also reverts change in rev. 1.36 to the documented
style of writing usage().

PR:		bin/29730
Submitted by:	Joseph Mallett <jmallett@xMach.org>
2001-08-15 15:11:52 +00:00
Ruslan Ermilov
ccb8bea4f0 The old fmt(1) always did what the new ``-l 8'' option does.
POLA: Changed the default to ``-l 8'' while still providing
a way to disable this feature with ``-l 0''.

PR:		bin/29247
Reviewed by:	iedowse
2001-08-15 14:53:55 +00:00
Ruslan Ermilov
d628d776c4 mdoc(7) police: utilize the new .Ex macro. 2001-08-15 09:09:47 +00:00
Kazuo Horikawa
d8ac53f249 Removal of following export controll related sentences:
o This option is not available outside of the United States and Canada.
o Because of export controls, TELNET ENCRYPT option is not supported outside
  of the United States and Canada.

src/crypto/README revision 1.5 commit log says:
> Crypto sources are no longer export controlled:
> Explain, why crypto sources are still in crypto/.
and actually telnet encryption is used outside of US and Canada now.

Pointed out by: OHSAWA Chitoshi <ohsawa@catv1.ccn-net.ne.jp>
Reviewed by:no objection on doc
2001-08-15 01:23:30 +00:00
Jens Schweikhardt
fa7a1ab968 Add hint about how we name profiled libraries (append _p at the right place).
PR:		8061
Submitted by:	Brandon Gillespie <brandon@ice.cold.org>
Reviewed by:	joerg, ru
MFC after:	5 weeks
2001-08-14 17:48:29 +00:00
Thomas Gellekum
566f6e4f1e Fix INT 10:09 (write char) and INT 10:0a (write char and attribute)
when cursor is at the lower right corner.

PR:		29574 29601
Submitted by:	Nils M Holm <nmh@t3x.org>
2001-08-14 11:57:14 +00:00
Thomas Gellekum
f7448f4297 Move update of BIOS variable at 0x6c (time counter) completely to timer.c.
Suggested by:	Igor Serikov <bt@turtle.pangeatech.com>
2001-08-14 11:54:37 +00:00
Ruslan Ermilov
753d686d34 mdoc(7) police: s/BSD/.Bx/ where appropriate. 2001-08-14 10:01:54 +00:00
Dima Dorfman
dd6ba956da An empty at.deny doesn't mean everyone can use at.
PR:		29549
Submitted by:	swear@aa.net
2001-08-14 06:41:20 +00:00
Peter Wemm
9a2e7f1520 Initialize outfile in main() 2001-08-13 21:59:04 +00:00
Peter Wemm
668f24deae Initialize msg in main() 2001-08-13 21:58:16 +00:00
Peter Wemm
ec26f57025 Initialize fp in main() 2001-08-13 21:57:12 +00:00
Peter Wemm
c7a12b501b Initialize debugf in main() 2001-08-13 21:56:39 +00:00
Ruslan Ermilov
ed2879a5cf mdoc(7) police: s;BSD/OS;.Bsx; where appropriate. 2001-08-13 17:07:40 +00:00
Ruslan Ermilov
c5e7e03a14 Spell "FreeBSD" with "F" and "BSD" in uppercase. 2001-08-13 16:33:00 +00:00
Ruslan Ermilov
8af1452cf8 Removed duplicate VCS ID tags, as per style(9). 2001-08-13 14:06:34 +00:00
Mike Barcroft
ede8b1c50a Fix some bogus strncpy(3) to strlcpy(3) changes I made in the previous
revision.  <utmp.h> structures don't leave room for a NUL character.
Also fix "UNKNOWN" which should have just been UNKNOWN.

Pointed out by:	bde
2001-08-13 05:56:27 +00:00
Mark Murray
37ee76af52 Remove the WANT_INSECURE_OPIE option - it is now a default. This is not
nearly as ominous as it sounds, and it allows OPIE to be used over SSH
and on xterms.

Requested by:	ache
Discussed on:	-security
2001-08-12 18:47:56 +00:00
Mike Barcroft
9ab4f41231 o Replace occurrences of strncpy(3) with strlcpy(3); most of
the uses of it were wrong anyway.
o Always check for NULL returns on strdup(3).
o Fix a possible buffer overflow in strcpy(3).
o Fix a format string vulnerability.
o t->ty_type in stypeof() could be NULL and eventually cause
  a segmentation fault in setenv(3), so check for that.

Eyeballed by:	kris
Reviewed by:	murray
MFC after:	3 days
2001-08-12 17:54:49 +00:00
Kenneth D. Merry
9674f1d43a Change the compute_stats() call to the new devstat_compute_statistics()
interface.

Cast the return of the rest of the printfs in here to void.

Submitted by:	"Sergey A. Osokin" <osa@freebsd.org.ru>
2001-08-11 19:41:56 +00:00
Mark Murray
788222e410 Set the RUSER for PAM so that (eg) kerberos can set up tickets properly. 2001-08-11 14:24:13 +00:00
Mark Murray
8cc3b02f98 WARNS=2 type cleanup.
WARNS=2 cannot be enable because of an unresolvable conflict in arg 2
of execv(). Document this in the Makefile.

Reviewed by:	bde (su.c only)
2001-08-11 14:22:32 +00:00
Kris Kennaway
57c6bd978f Don't call errx() with a variable format string
MFC after:	1 week
2001-08-11 00:49:11 +00:00
Ruslan Ermilov
94ba280c59 mdoc(7) police: join split punctuation to macro calls. 2001-08-10 17:35:21 +00:00
Ruslan Ermilov
57e4378bf6 mdoc(7) police: protect trailing full stops of abbreviations
with a trailing zero-width space: `e.g.\&'.
2001-08-10 13:45:36 +00:00
Ruslan Ermilov
3ce0d6e846 mdoc(7) police: fix markup. 2001-08-10 10:43:45 +00:00
Ruslan Ermilov
95d6ec368c Update for 3.36. 2001-08-09 14:38:45 +00:00
Ruslan Ermilov
5a32eb6470 Update for 3.36.
Reduce diffs to distributed, man(7) format, version.
Markup nits.
2001-08-09 14:38:10 +00:00
Dima Dorfman
ca0589467f Style fix: use .else where appropriate.
PR:		29489
Submitted by:	Joseph Mallett <jmallett@xMach.org>
2001-08-09 07:03:11 +00:00
Dima Dorfman
e896c344fb Print the peer's name and address in the "Connection establish"
message.  Similar information is given by the talk daemon when a
connection is requested, but that part isn't on the screen when the
main "talk" screen appears, and sometimes it's nice to know who you're
talking to.

Reviewed by:	ru
2001-08-09 06:45:35 +00:00
Yaroslav Tykhiy
d691b79fbc Replace the condemned access(2) by stat(2),
as per the discussion in -audit.
2001-08-08 21:22:48 +00:00
Sheldon Hearn
42abf713c9 can not -> cannot 2001-08-08 18:32:06 +00:00
David E. O'Brien
bef2f61da3 Clean up this thing a little. 2001-08-08 16:19:30 +00:00
David E. O'Brien
9732caee1b Support the new "-i" (output MIME type strings) option by installing
the MIME files (both regular and precompiled).
2001-08-08 16:10:16 +00:00
David E. O'Brien
8c662313ce Build and use the precompiled magic file. Precompiled magic files have
been supported since version 3.35, however it is just with version 3.36
that file has become verbose about it.
2001-08-08 15:53:58 +00:00
Ruslan Ermilov
5873dc7271 Add entry for wsanchez. 2001-08-08 15:35:20 +00:00
Thomas Gellekum
31769c6186 Silence some more warnings, mostly from `-W -Wwrite-strings'. 2001-08-08 10:58:50 +00:00
Dag-Erling Smørgrav
03f28475f8 Allow the user to specify port ranges against which to match inet sockets.
Suggested by:	roam
2001-08-07 19:59:52 +00:00
Ruslan Ermilov
c4d9468ea0 mdoc(7) police:
Avoid using parenthesis enclosure macros (.Pq and .Po/.Pc) with plain text.
Not only this slows down the mdoc(7) processing significantly, but it also
has an undesired (in this case) effect of disabling hyphenation within the
entire enclosed block.
2001-08-07 15:48:51 +00:00
Ruslan Ermilov
489c40dcf5 mdoc(7) police: bump document date for the previous delta. 2001-08-07 13:45:55 +00:00
Ruslan Ermilov
2909f5cf21 mdoc(7) police: sort xrefs. 2001-08-07 13:41:38 +00:00
Ruslan Ermilov
df3fa85144 mdoc(7) police: bump document date for the previous delta, fix markup. 2001-08-07 13:40:07 +00:00
Thomas Gellekum
9e6e8e9f89 Fix warnings resulting from `-Wredundant-decls -Wstrict-prototypes'. 2001-08-07 11:09:15 +00:00
Mike Barcroft
b5b9b43078 Constify, staticize, and set WARNS=2.
MFC after:	3 days
2001-08-06 23:20:06 +00:00