d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
219,247 Commits 6 Branches 133 Tags 2.6 GiB
35cfc322f1
Commit Graph

45 Commits

Author SHA1 Message Date
Enji Cooper
3daec7ae72 snmp_table_fetch_async: don't leak work if snmp_pdu_send(..) fails 
MFC after:	1 week
Reported by:	Coverity
CID:		1017276
 2017-01-05 08:49:06 +00:00
Enji Cooper
2e590d595e Use calloc instead of malloc with buffers in snmp_{recv,send}_packet 
This doesn't fix the issue noted in the PR, but at the very least it
cleans up the error so it looks a bit more sane, and in the event
that bsnmp did wander off into the weeds, the likelihood of it
crashing with more sensible output is greater, in my opinion

MFC counter set high so I have enough time to resolve the real
underlying bug in bsnmpwalk

MFC after:	1 month
PR:		215721
 2017-01-04 07:53:01 +00:00
Enji Cooper
84d0b89e96 Fix spelling errors; bump .Dd for the change 
MFC after:	3 days
 2017-01-01 05:23:01 +00:00
Enji Cooper
d1b4c796ac Bump .Dd for the spelling and .Nm updates 
MFC after:	3 days
 2017-01-01 05:16:24 +00:00
Enji Cooper
d075380571 Fix spelling errors 
MFC after:	3 days
Reported by:	igor
 2017-01-01 05:14:58 +00:00
Enji Cooper
ad52f0d10c bsnmpclient(3) also documents snmp_client_init, snmp_client_set_host, 
and snmp_client_set_port. Add them to the NAME section

MFC after:	3 days
 2017-01-01 05:13:54 +00:00
Enji Cooper
1cc49661ec snmp_discover_engine: fix up req/resp (PDU object) handling a bit 
- Call snmp_pdu_free on req and resp when done with the objects
- Call snmp_pdu_free on req before calling snmp_pdu_create on it
  again

MFC after:	1 week
 2016-12-31 23:20:57 +00:00
Enji Cooper
1e5211d238 Unbreak the build by passing the string to strdup, not its length 
MFC after:	1 week
X-MFC with:	r310931
Pointyhat to:	ngie
 2016-12-31 11:24:12 +00:00
Enji Cooper
bfb81e6524 Use strdup in snmp_parse_server(..) when possible instead of malloc+strcpy 
This simplifies the code and mutes a Coverity warning about sc->cport being
improperly allocated

Reported by:	Coverity
CID:		1018247
MFC after:	1 week
 2016-12-31 11:13:00 +00:00
Enji Cooper
6c9b7542ef Prevent improper memory accesses after calling snmp_pdu_free and snmp_value_free 
snmp_pdu_free: set pdu->nbindings to 0 to limit the damage that
could happen if a pdu was reused after calling the function, and
as both stack and heap allocation types are used in contrib/bsnmp
and usr.sbin/bsnmpd.

snmp_value_free: NULL out value->v.octetstring.octets after calling
free on it to prevent a double-free from occurring.

MFC after:      2 weeks
 2016-12-29 00:20:03 +00:00
Enji Cooper
700d391fb8 style(9): snmp_send_packet(..): fix whitespace 
MFC after:	3 days
 2016-12-28 04:56:15 +00:00
Enji Cooper
bc54857ed0 style(9): fix whitespace in pdu_encode_secparams(..) 
MFC after:	3 days
 2016-12-28 04:53:52 +00:00
Enji Cooper
e1d581b289 style(9): clean up trailing whitespace 
MFC after:	3 weeks
 2016-12-27 23:32:54 +00:00
Enji Cooper
6521e5f846 Be more strict about IpAddress type in snmp_value_parse(..) 
- Use inet_pton with AF_INET instead of doing longhand with sscanf.
- Use gethostbyname2 with AF_INET to ensure that the hostname isn't
  accidentally parsed with another address family, e.g. AF_INET6.

NB: IpAddress per RFC-2578 is IPv4 only. Work is in progress to add
    the InetAddress type and friends documented in RFC-4001 and
    elsewhere (which supports IPv4, IPv6, and more).

MFC after:	2 weeks
 2016-12-24 11:41:16 +00:00
Enji Cooper
3b9712fa95 Minor style(9) fixes 
- Trailing whitespace cleanup
- Sort variables in snmp_dialog(..) by alignment

No functional change

MFC after:	1 week
 2016-12-24 11:30:24 +00:00
Enji Cooper
846157438d Sort #includes 
No functional change

MFC after:	3 days
 2016-12-24 11:26:55 +00:00
Enji Cooper
7c25494706 Clean up trailing and leading whitespace 
Fix variable type alignment in snmp_dialog(..)

MFC after:	1 week
 2016-12-18 05:31:54 +00:00
Shteryana Shopova
3b49535a5a Reply to a snmpEngineID discovery PDU with a Report PDU as per the 
requirements of RFC 3414 section 4.

PR:	174974
Submitted by:	pguyot@kallisys.net
Reported by:	several people
Reviewed by:	bz@
 2016-11-10 20:51:26 +00:00
Shteryana Shopova
1108712cb5 Fix a regression introduced in SVN r256678 that breaks USM header parsing 
Reviewed by:	bz@
 2016-10-24 21:05:23 +00:00
Enji Cooper
e3ee0494af Fix the function signatures when MK_CRYPT == no for snmp_get_local_keys and 
snmp_passwd_to_keys

MFC after: 1 week
Reported by: Beeblebrox <zaphod@berentweb.com>
 2014-12-27 20:58:01 +00:00
Hartmut Brandt
30b5118d51 Fix a problem with OBJECT IDENTIFIER encoding: need to check the 
second subid to be less than 40, not the first when the first
subid is 0 or 1.
 2014-01-21 16:49:54 +00:00
Xin LI
ecd241b619 Fix bsnmpd remote denial of service vulnerability. 
Reported by:	dinoex
Submitted by:	harti
Security:	FreeBSD-SA-14:01.bsnmpd
Security:	CVE-2014-1452
 2014-01-14 18:58:57 +00:00
Shteryana Shopova
546401ce54 Fix the -Wconversion warnings produced when compiling the SNMP agent. 2013-10-17 12:03:17 +00:00
Shteryana Shopova
0698344859 Fix SNMP Error response PDUs and properly encode them when using v3 auth/encryption. 
Reported by:	harti@
 2013-10-17 11:49:46 +00:00
Pedro F. Giffuni
646a7fea0c Clean some 'svn:executable' properties in the tree. 
Submitted by:	Christoph Mallon
MFC after:	3 days
 2013-01-26 22:08:21 +00:00
Joel Dahl
bef04523e3 Remove end of line whitespace. 2012-06-17 11:36:28 +00:00
Joel Dahl
0aa9c2d892 Minor mdoc fixes. 2012-06-17 11:33:55 +00:00
Shteryana Shopova
72cd7a520d Bring in a SNMP module that allows configuration of SNMPv3 Notification targets. 
Sponsored by:	The FreeBSD Foundation
Reviewed by:	philip
Approved by:	philip
 2010-12-20 17:13:14 +00:00
Shteryana Shopova
2b8026620c Silence the compiler warnings in libbsnmp by removing several (now) 
unsed parameters.

Sponsored by:	The FreeBSD Foundation
Reviewed by:	philip@
 2010-12-16 11:20:37 +00:00
Shteryana Shopova
e9a4946830 Add a forgotten file from r216294 and unbreak the build. 
Sponsored by:	The FreeBSD Foundation
Reviewed by:	philip@ (mostly)
Approved by:	philip@
 2010-12-08 15:52:06 +00:00
Shteryana Shopova
135f7de5dd In bsnmpd(1) add support for SNMPv3 message processing model, including message authentication, packet encryption & view-based access control (RFC 3412, 3414, 3415). 
Sponsored by:	The FreeBSD Foundation
Reviewed by:	philip@ (mostly)
Approved by:	philip@
 2010-12-08 13:51:38 +00:00
Ulrich Spörlein
7cc1fde083 mdoc: drop even more redundant .Pp calls 
No change in rendered output, less mandoc lint warnings.

Tool provided by:	Nobuyuki Koganemaru n-kogane at syd.odn.ne.jp
 2010-10-19 12:35:40 +00:00
Ulrich Spörlein
4f13bbb691 mdoc: consistently spell our email addresses <foo@FreeBSD.org> 
Reviewed by:	ru
Approved by:	harti
 2010-05-24 06:26:38 +00:00
Hartmut Brandt
568d256aa1 This commit was generated by cvs2svn to compensate for changes in r156066, 
which included commits to RCS files with non-trunk default branches.
 2006-02-27 16:16:18 +00:00
Hartmut Brandt
748b5b1ebd Virgin import of bsnmpd 1.12 2006-02-27 16:16:18 +00:00
Hartmut Brandt
4c0a7af955 Vendor fix for the build problem of snmp_pf. Move the fallback definitions 
for U?INT32_{MAX,MIN} from asn1.h into the .c files that actually require
them (the .h file doesn't refer to these macros).
 2005-10-05 15:19:56 +00:00
Hartmut Brandt
bb5e059e0d This commit was generated by cvs2svn to compensate for changes in r150974, 
which included commits to RCS files with non-trunk default branches.
 2005-10-05 15:19:56 +00:00
Hartmut Brandt
e50dd7e071 These files are not needed and were imported by accident in the 
previous import.
 2005-10-04 14:51:55 +00:00
Hartmut Brandt
165c5d31cb Virgin import of bsnmpd 1.11 2005-10-04 14:41:06 +00:00
Hartmut Brandt
69292ced51 Virgin import of bsnmpd 1.10 2005-05-23 11:19:11 +00:00
Hartmut Brandt
94caccb357 Virgin import of bsnmpd 1.8 2005-02-28 17:27:11 +00:00
Hartmut Brandt
896052c10f Virgin import of bsnmpd 1.7 2004-08-06 13:38:30 +00:00
Hartmut Brandt
8eecd77ad5 Import of bsnmpd 1.6 2004-04-14 16:20:14 +00:00
Hartmut Brandt
70af00a124 Virgin import of bsnmpd 1.5a 2004-01-23 10:44:47 +00:00
Hartmut Brandt
f06ca4af18 Virgin import of bsnmp 1.4 2003-11-10 08:53:38 +00:00