d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
208,254 Commits 6 Branches 133 Tags
Commit Graph

161 Commits

Author SHA1 Message Date
Michael Tuexen
fe4a59b30a Stop processing of a SACK when the association has been aborted. 
MFC after: 3 days
 2015-12-21 18:52:02 +00:00
Michael Tuexen
d96bef9c77 Ensure that outgoing streams get reset when they run dry. 
MFC after:	1 week
 2015-12-03 15:19:29 +00:00
Michael Tuexen
0bfc52bea5 Use the correct length. The wrong one was too large. 
MFC after: 3 days
 2015-11-06 22:08:05 +00:00
Michael Tuexen
b70b526d17 Fix typos in field names of struct sctp_extrcvinfo. 
Provide defines to allow applications to compile.
Thanks to Jens Hoelscher for making me aware of the typos.

MFC after: 1 week
 2015-11-06 13:08:16 +00:00
Michael Tuexen
86eda749af Cleanup the handling of error causes for ERROR chunks. This fixes 
an inconsistency of the padding handling. The final padding is
now considered to be a chunk padding.

MFC after:	1 week
 2015-09-12 17:08:51 +00:00
Michael Tuexen
e629b9fc56 Ensure that ERROR chunks are always padded by implementing this 
in the routine, which queues an ERROR chunk, instead on relyinh
on the callers to do so. Since one caller missed this, this actially
fixes a bug.

MFC after:	1 week
 2015-09-11 13:54:33 +00:00
Michael Tuexen
e7e71dd7f3 Don't take the port numbers for packets containing ABORT chunks from 
a freed mbuf. Just use them from the stcb.

MFC after: 3 days
 2015-08-02 16:07:30 +00:00
Michael Tuexen
9ae56375af Fix a typo reported by Erik Cederstrand. 
MFC after: 	1 week
 2015-07-28 08:50:13 +00:00
Michael Tuexen
267dbe63a1 Provide consistent error causes whenever an ABORT chunk is sent. 
MFC after:	1 week
 2015-07-27 22:35:54 +00:00
Michael Tuexen
cf9e47b2f0 Improve locking on Mac OS X. This does not change the functionality 
on FreeBSD.

Reviewed by:	rrs
MFC after:	1 week
 2015-07-26 10:37:40 +00:00
Michael Tuexen
6247db3541 Fix and improve a debug message. The SID was reported as an SSN. 
MFC after:	1 week
 2015-07-26 10:17:17 +00:00
Randall Stewart
7cca17758c Fix several problems with Stream Reset. 
1) We were not handling (or sending) the IN_PROGRESS case if
    the other side (or our side) was not able to reset (awaiting more data).
 2) We would improperly send a stream-reset when we should not. Not
    waiting until the TSN had been assigned when data was inqueue.

Reviewed by:	tuexen
 2015-07-22 11:30:37 +00:00
Michael Tuexen
b7d130befc Fix and cleanup the debug information. This has no user-visible changes. 
Thanks to Irene Ruengeler for proving a patch.

MFC after: 3 days
 2015-05-28 16:00:23 +00:00
Michael Tuexen
548f47a8f1 Address some compiler warnings. No functional change. 
MFC after: 3 days
 2015-05-28 14:24:21 +00:00
Michael Tuexen
55f8a4bb1b Don't panic under INVARIANTS when receiving a SACK which cumacks 
a TSN never sent.
While there, fix two typos.

MFC after: 1 week
 2015-04-26 21:47:15 +00:00
Michael Tuexen
8427b3fd4f Fix the bug in the handling of fragmented abandoned SCTP user messages reported in 
https://code.google.com/p/sctp-refimpl/issues/detail?id=11
Thanks to Lally Singh for reporting it.
MFC after: 3 days
 2015-03-24 15:05:36 +00:00
Michael Tuexen
4be807c4d6 Minimize the usage of SCTP_BUF_IS_EXTENDED. 
This should help Robert...
 2015-01-10 20:49:57 +00:00
Michael Tuexen
457b4b8836 This is the SCTP specific companion of 
https://svnweb.freebsd.org/changeset/base/275358
which was provided by Hans Petter Selasky.
 2014-12-04 21:17:50 +00:00
Michael Tuexen
4e88d37a2a Do the renaming of sb_cc to sb_ccc in a way with less code changes by 
using a macro.
This is an alternate approach to
https://svnweb.freebsd.org/changeset/base/275326
which is easier to handle upstream.

Discussed with: rrs, glebius
 2014-12-02 20:29:29 +00:00
Gleb Smirnoff
0f9d0a73a4 Merge from projects/sendfile: 
o Introduce a notion of "not ready" mbufs in socket buffers.  These
mbufs are now being populated by some I/O in background and are
referenced outside.  This forces following implications:
- An mbuf which is "not ready" can't be taken out of the buffer.
- An mbuf that is behind a "not ready" in the queue neither.
- If sockbet buffer is flushed, then "not ready" mbufs shouln't be
  freed.

o In struct sockbuf the sb_cc field is split into sb_ccc and sb_acc.
  The sb_ccc stands for ""claimed character count", or "committed
  character count".  And the sb_acc is "available character count".
  Consumers of socket buffer API shouldn't already access them directly,
  but use sbused() and sbavail() respectively.
o Not ready mbufs are marked with M_NOTREADY, and ready but blocked ones
  with M_BLOCKED.
o New field sb_fnrdy points to the first not ready mbuf, to avoid linear
  search.
o New function sbready() is provided to activate certain amount of mbufs
  in a socket buffer.

A special note on SCTP:
  SCTP has its own sockbufs.  Unfortunately, FreeBSD stack doesn't yet
allow protocol specific sockbufs.  Thus, SCTP does some hacks to make
itself compatible with FreeBSD: it manages sockbufs on its own, but keeps
sb_cc updated to inform the stack of amount of data in them.  The new
notion of "not ready" data isn't supported by SCTP.  Instead, only a
mechanical substitute is done: s/sb_cc/sb_ccc/.
  A proper solution would be to take away struct sockbuf from struct
socket and allow protocols to implement their own socket buffers, like
SCTP already does.  This was discussed with rrs@.

Sponsored by:	Netflix
Sponsored by:	Nginx, Inc.
 2014-11-30 12:52:33 +00:00
Michael Tuexen
dd973b0e15 Add support for the SCTP_PR_SUPPORTED socket option as specified in 
http://tools.ietf.org/html/draft-ietf-tsvwg-sctp-prpolicies
Add also a sysctl controlling the default of the end-points.

MFC after: 1 week
 2014-08-02 21:36:40 +00:00
Michael Tuexen
ce11b8429b Cleanup sctp_send_initiate() and sctp_send_initiate_ack() to be 
in sync as much as possible. This simplifies upcoming changes.
 2014-08-01 12:42:37 +00:00
Xin LI
e432298ade Initialize SCTP cmsg's and notification's buffer before copying out 
to userland.

Submitted by:	tuexen
Security:	CVE-2014-3953
Security:	FreeBSD-SA-14:17.kmem
 2014-07-08 21:54:27 +00:00
Michael Tuexen
8be0fd55dc Don't free an mbuf twice. This only happens in very rare error 
cases where the peer sends illegal sequencing information in
DATA chunks for an existing association.

MFC after: 3 days.
 2014-04-23 21:20:55 +00:00
Michael Tuexen
eb67ee5fc6 Add consistency checks to ensure that fragments of a user message 
have the same U-bit.

MFC after: 3 days
 2014-04-20 21:11:39 +00:00
Michael Tuexen
2dec1efc5a Use consistently debug output instead of an unconditional printf. 
MFC after: 3 days
 2014-04-19 20:55:51 +00:00
Michael Tuexen
32451da416 Send the correct error cause, when a DATA chunk with no user data 
is received. This bug was reported by Irene Ruengeler.

MFC after: 3 days
 2014-04-19 19:21:06 +00:00
Michael Tuexen
ff1ffd7499 * Provide information in error causes in ASCII instead of 
proprietary binary format.
* Add support for a diagnostic information error cause.
  The code is sysctlable and the default is 0, which
  means it is not sent.

This is joint work with rrs@.

MFC after: 1 week
 2014-03-16 12:32:16 +00:00
Michael Tuexen
04194e4f7d Remove a stray write operation. 
MFC after: 3 days
 2013-11-16 16:09:09 +00:00
Michael Tuexen
d4d23375d3 When computing the partial delivery point, take the 
receiver socket buffer size correctly into account.

MFC after: 1 week
 2013-09-07 00:45:24 +00:00
Michael Tuexen
0ddb429900 Remove redundant field pr_sctp_on. 
MFC after: 1 week
 2013-09-03 19:31:59 +00:00
Michael Tuexen
2c9c61defa Make the features a 64-bit value instead of 32-bit. 
This will allow an easier integration of the support
for NDATA.
While there, do also some minor cleanups.
Obtained from:	rrs@
MFC after: 2 weeks
 2013-08-12 13:52:15 +00:00
Michael Tuexen
56f778aadf Code cleanups. 
MFC after: 3 days
 2013-07-03 18:48:43 +00:00
Michael Tuexen
c53f854a17 Don't send kernel provided information in the User Initiated 
ABORT cause, since the user can also provide this kind of
information. So the receiver doesn't know who provided the
information.
While there: Fix a bug where the stack would send a malformed
ABORT chunk when using a send() call with SCTP_ABORT|SCT_SENDALL
flags.

MFC after: 3 days
 2013-02-11 13:57:03 +00:00
Michael Tuexen
c39cfa1f7e Fix a bug where HEARTBEATs were still sent in SHUTDOWN_SENT or 
SHUTDOWN_ACK_SENT state. While there, make the corresponding
code consistent.

MFC after: 1 week
 2013-02-09 08:27:08 +00:00
Gleb Smirnoff
eb1b1807af Mechanically substitute flags from historic mbuf allocator with 
malloc(9) flags within sys.

Exceptions:

- sys/contrib not touched
- sys/mbuf.h edited manually
 2012-12-05 08:04:20 +00:00
Michael Tuexen
325c8c46b1 Get the accounting working. We now have counters how many 
chunks for each SCTP outgoing stream are in the send and
sent queue.
While there, improve the naming of NR-SACK related constants
recently introduced.

MFC after: 1 week
 2012-11-16 19:39:10 +00:00
Michael Tuexen
a7ad6026e0 Add per outgoing stream accounting for chunks in the send 
and sent queue. This provides no functional change, but is
a preparation for an upcoming stream reset improvement.
Done with rrs@.

MFC after: 1 week
 2012-11-07 22:11:38 +00:00
Michael Tuexen
2a4985847a Add some missing changes missed in the last commit. 
MFC after: 1 week
X-MFC with: 242708
 2012-11-07 21:25:32 +00:00
Michael Tuexen
98f2956c11 Improve PR-SCTP if used in combination with NR-SACK. 
Based on work done by Mohammad Rajiullah.

MFC after: 1 week
 2012-11-07 20:59:00 +00:00
Michael Tuexen
a169d6ec2b Don't include a structure containing a flexible array in another 
structure.

MFC after:	10 days
 2012-09-07 13:36:42 +00:00
Michael Tuexen
dd294dcec6 Using %p in a format string requires a void *. 
MFC after: 10 days
 2012-09-05 18:52:01 +00:00
Michael Tuexen
b1754ad17b Pass the src and dst address of a received packet explicitly around. 
MFC after: 3 days
 2012-06-28 16:01:08 +00:00
Michael Tuexen
39803b8c58 Whitespace cleanup. 
MFC after: 3 days
 2012-06-25 17:15:09 +00:00
Michael Tuexen
20cc2188f3 Pass the packet length explicitly around. 
MFC after: 3 days
 2012-06-24 23:12:24 +00:00
Michael Tuexen
f30ac43257 Pass flowid explicitly through the stack instead of taking it from 
the mbuf chain at different places.
While there: Fix several bugs related to VRFs.

MFC after: 3 days
 2012-06-14 06:54:48 +00:00
Michael Tuexen
807aad636f Use consistent text at the begining of the files. 
MFC after: 3 days
 2012-05-23 11:26:28 +00:00
Michael Tuexen
1edc9dbae5 Provide in the SCTP_SEND_FAILED and SCTP_SEND_FAILED_EVENT notifications 
the correct ssf_error or ssfe_error as required by RFC 6458.

MFC after: 3 days
 2012-05-13 19:32:49 +00:00
Michael Tuexen
4b1f78e1af Provide the error code in SCTP_PEER_ADDR_CHANGE notifications as 
specified in RFC 6458.

MFC after: 3 days
 2012-05-13 17:36:04 +00:00
Michael Tuexen
a2b42326b5 Provide in the association change notification the received ABORT chunk 
if case of SCTP_COMM_LOST or SCTP_CANT_STR_ASSOC as required by RFC 6458.

MFC after: 3 days
 2012-05-12 20:11:35 +00:00