d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
196,025 Commits 6 Branches 133 Tags
Commit Graph

107 Commits

Author SHA1 Message Date
Alexander Motin
3f9e1172b7 Slightly polish iSCSI parameters negotiation. 
MFC after:	1 week
 2014-12-19 01:12:22 +00:00
Alexander Motin
2124e3b07f Make sequence numbers checks more strict. 
While we don't support MCS, hole in received sequence numbers may mean
only PDU loss.  While we don't support lost PDU recovery, terminate the
connection to avoid stuck commands.

While there, improve handling of sequence numbers wrap after 2^32 PDUs.

MFC after:	2 weeks
 2014-12-17 15:13:21 +00:00
Alexander Motin
1606ad8c42 Do not corrupt the listen string when parsing it. 
This fixes problem with ctld reload when it is configured to listen on two
portals with same IP, but different ports.

MFC after:	1 week
 2014-12-03 09:32:51 +00:00
Edward Tomasz Napierala
0dd2bee428 Fix null pointer dereference. 
MFC after:	2 weeks
Coverity CID:	1256497
Sponsored by:	The FreeBSD Foundation
 2014-12-02 07:42:25 +00:00
Baptiste Daroussin
c6db8143ed Convert usr.sbin to LIBADD 
Reduce overlinking
 2014-11-25 16:57:27 +00:00
Edward Tomasz Napierala
b822a99413 Remove the pidfile clause from the ctl.conf example. Why do everyone 
just copy/paste this line into their configs, it's beyond me.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-11-24 08:13:44 +00:00
Alexander Motin
8b94b5836c For both iSCSI initiator and target increase socket buffer sizes before 
establishing connection.

This is a workaround for Chelsio TOE driver, that does not update socket
buffer size in hardware after connection established, and unless that is
done beforehand, kernel code will stuck, attempting to send/receive full
PDU at once.

MFC after:	1 week
 2014-11-22 15:09:18 +00:00
Alexander Motin
6de78f9f24 In conf_apply() remove iSCSI ports from kernel before removing LUNs. 
Previous order confused initiators with messages about "removed" LUNs
during simple ctld restart without any real config change.  After this
commit initiators only reestablish lost connection, receive "Power on
occurred" UNIT ATTENTION status and continue normal operation.

MFC after:	1 month
 2014-11-21 18:00:00 +00:00
Edward Tomasz Napierala
9f4958782a Fix error handling. 
MFC after:	1 month
Coverity CID:	1249768
Sponsored by:	The FreeBSD Foundation
 2014-11-21 16:14:32 +00:00
Edward Tomasz Napierala
e48bb73a2a Add missing error checking for kernel_port_{add,remove}(). Both can fail 
for reasons yet unknown; don't make it increment cumulated_error as a kind
of temporary workaround.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-11-21 12:35:18 +00:00
Alexander Motin
40259c79cd Make both iSCSI initiator and target support base64 encoded CHAP data. 
While all tested initiators and targets use hex-encoded CHAP data, RFC also
allows base64 encoding there, and Microsoft certificaition tool uses it.

Reviewed by:	trasz (earlier version)
MFC after:	2 weeks
Sponsored by:	iXsystems, Inc.
 2014-11-09 20:39:08 +00:00
Edward Tomasz Napierala
d02d7de76c Add HISTORY section to ctld(8). 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-11-09 13:45:35 +00:00
Edward Tomasz Napierala
7889a0832f Fix several nits in redirection handling - don't use wrong CSG, 
and avoid use-after-free.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-11-09 13:30:02 +00:00
Edward Tomasz Napierala
6dbdbf825d Add support for sending redirections to iSCSI target. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-11-09 13:01:09 +00:00
Edward Tomasz Napierala
1195fe34b0 Improve wording in ctl.conf(5). 
Differential Revision:	https://reviews.freebsd.org/D1020
Reviewed by:	bcr@ (earlier version), wblock@
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-11-08 07:54:34 +00:00
Edward Tomasz Napierala
aed31534cd ctld(8) doesn't require -lcam or -lssl; remove those from DPADD and LDADD. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-11-08 07:50:57 +00:00
Alexander Motin
d5cc4a4a61 Remove unused assignments, noticed by Clang analyzer. 
MFC after:	1 week
 2014-11-07 19:32:10 +00:00
Edward Tomasz Napierala
1cb587dc9c Fix iscsictl(8) and ctld(8) to correctly handle Windows newlines 
(CRLF) in iscsi.conf and ctl.conf.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-29 12:22:32 +00:00
Edward Tomasz Napierala
dbb1ee18cc Keep the token list sorted. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-29 12:12:27 +00:00
Edward Tomasz Napierala
f948858032 Make it possible to optionally use semicolon to separate statements. 
This makes it possible to format stuff like this:

target xxx {
	lun 0 { path /foo/bar; size 4G; }
}

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-29 12:10:39 +00:00
Edward Tomasz Napierala
bd833b11c2 Simplify code; no functional changes. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-29 09:36:02 +00:00
Edward Tomasz Napierala
0537488353 Add discovery-filter. This makes it possible to restrict which targets 
are returned during discovery based on initiator portal, name, and CHAP
credentials.

Reviewed by:	mav@
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-29 09:26:55 +00:00
Edward Tomasz Napierala
be6527d545 Document iSNS defaults. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-28 17:11:51 +00:00
Edward Tomasz Napierala
d9b4554dbd Fix build after previous commit. While here, improve error messages. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-28 10:39:29 +00:00
Edward Tomasz Napierala
4524db570f Remove the distinction between strings and numbers from ctld(8) yacc parser. 
This fixes problems with passing strings that look like numbers to clauses
that expect strings; previously it caused syntax errors and had to be worked
by user, using quotes.  The workaround introduced in r267833 is no longer
neccessary.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-28 10:25:59 +00:00
Alexander Motin
829603e21f Add basic iSNS client to the iSCSI target. 
This makes ctld(8) register its iSCSI targets and portals on configured
iSNS servers to allow initiators find them without active discovery.

Fetching of allowed initiators from iSNS is not implemented now, so target
ACLs still should be configured manually.

Reviewed by:	trasz@
MFC after:	1 month
Sponsored by:	iXsystems, Inc.
 2014-10-25 12:50:26 +00:00
Edward Tomasz Napierala
3bea5b97f8 Improve ctld.conf example. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-24 12:30:43 +00:00
Edward Tomasz Napierala
e867e16225 Make the initiator-name and initiator-portal checks a little nicer. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-24 11:40:09 +00:00
Edward Tomasz Napierala
ff982835f8 Tidy up the login code; no functional changes. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-24 11:34:55 +00:00
Edward Tomasz Napierala
7c8e3a7f48 Clean up (refactor) discovery a little; no functional changes. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-23 12:02:27 +00:00
Edward Tomasz Napierala
a178d09eee Fix ctl.conf example to use proper paths to ZVOLs. 
Sponsored by:	The FreeBSD Foundation
 2014-10-22 11:30:56 +00:00
Edward Tomasz Napierala
4af184b9f7 Remove misleading statement. Bump date. 
MFC after:	1 month
Sponsored by:	FreeBSD Foundation
 2014-10-22 11:09:03 +00:00
Edward Tomasz Napierala
3a6accd5a5 Comment out parts about iSER; it's not implemented. 
Sponsored by:	The FreeBSD Foundation
 2014-10-22 11:06:05 +00:00
Edward Tomasz Napierala
e2eb7f476c Remove spurious empty line. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-22 10:53:25 +00:00
Edward Tomasz Napierala
4e5c38f8b7 Fix ctld(8) to not show the "auth-group <name> not assigned to any target" 
warning for auth-groups assigned to a portal-group.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-22 09:40:46 +00:00
Edward Tomasz Napierala
2bd282696a Whitespace fixes. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-22 09:17:17 +00:00
Edward Tomasz Napierala
45078155e3 Untangle iSCSI authentication code by splitting off the CHAP 
implementation.

Reviewed by:	mav@
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-22 08:59:23 +00:00
Alexander Motin
19720f4113 Make ctld start even if some LUNs are unable to open backing storage. 
Such LUNs will be visible to initiators, but return "not ready" status
on media access commands.  If backing storage become available later,
`ctladm modify ...` or `service ctld reload` can trigger its reopen.
 2014-10-10 19:41:09 +00:00
Alexander Motin
8cf98331b0 Make kernel to update LUN size from the backing storage on configuration 
reload also if that size was not specified in the new configuration.

Previously it happened only if size was explicitly changed in config.

MFC after:	3 days
 2014-09-18 17:39:04 +00:00
Edward Tomasz Napierala
4f66b23341 Fix two small nits in ctl.conf(5). 
MFC after:	3 days
Sponsored by:	The FreeBSD Foundation
 2014-09-14 08:35:44 +00:00
Allan Jude
ce20734f95 Resolve an ambiguity with the definition of a new auth-group 
Resolve a markup mistake

Reviewed by:	trasz
Approved by:	bcr (mentor), wblock (mentor)
Sponsored by:	ScaleEngine Inc.
CR:		https://reviews.freebsd.org/D735
 2014-09-13 23:50:51 +00:00
Allan Jude
263be6a9d1 Fix minor syntax error 
Submitted by:	bjk
Approved by:	bcr (mentor)
Sponsored by:	ScaleEngine Inc.
 2014-09-12 00:55:42 +00:00
Allan Jude
d1e933edda Improve markup and language throughout the ctl.conf man page 
Reviewed by:	trasz
Approved by:	bcr (mentor)
Sponsored by:	ScaleEngine Inc.
 2014-09-12 00:08:19 +00:00
Edward Tomasz Napierala
2e779f745b Use keys_add_int() where appropriate. No functional changes. 
Sponsored by:	The FreeBSD Foundation
 2014-09-09 16:57:02 +00:00
Edward Tomasz Napierala
dce704a67a Fix ctld(8) to not forget to send TargetPortalGroupTag and TargetAlias 
when the initiator skips security negotiation.  This fixes interoperability
with Xtend SAN initiator.

PR:		193021
MFC after:	1 week
Sponsored by:	The FreeBSD Foundation
 2014-09-09 16:45:36 +00:00
Edward Tomasz Napierala
44a5953aa1 Avoid ctld(8) crash on getaddrinfo(3) failure. 
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
 2014-09-06 09:03:13 +00:00
Edward Tomasz Napierala
a5f9f526bd Document initiator-portal netmask support. 
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
 2014-09-05 14:58:24 +00:00
Edward Tomasz Napierala
0488e848d9 Turn two errors, which are possible to trigger only by bugs, 
into assertions.

Discussed with:	mav@
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
 2014-09-05 14:48:06 +00:00
Edward Tomasz Napierala
d69440367c Fix typo. 
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
 2014-09-05 11:10:44 +00:00
Edward Tomasz Napierala
b7a65e3936 Make the iSCSI stack use __FBSDID() properly. 
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
 2014-08-21 15:32:38 +00:00