d/freebsd-nq
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
212,277 Commits 6 Branches 133 Tags 2.6 GiB
9a6844d55f
Commit Graph

165 Commits

Author SHA1 Message Date
Don Lewis
ec77f107fa pdu_delete(request) frees request, so move the call after 
login_new_response(request) to avoid a use-after-free error

Reported by:	Coverity
Reviewed by:	1331219, 1331220
 2016-05-16 04:43:47 +00:00
Edward Tomasz Napierala
e321146fc5 Make the usage() mention the -u option added in r295212. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2016-04-12 16:07:41 +00:00
Edward Tomasz Napierala
e19462c33b Use the log_errno value passed to the function instead of the errno global 
variable.

Suggested by:	Daniel Braniss
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2016-03-15 11:03:45 +00:00
Jakub Wojciech Klama
bb3844b388 Check value returned from ucl_parser_add_file(). 
Reviewed by:	trasz
Approved by:	trasz (mentor)
MFC after:	1 month
Sponsored by:	iXsystems, Inc.
 2016-03-13 19:50:17 +00:00
Bryan Drewery
bd18fd57db DIRDEPS_BUILD: Regenerate without local dependencies. 
These are no longer needed after the recent 'beforebuild: depend' changes
and hooking DIRDEPS_BUILD into a subset of FAST_DEPEND which supports
skipping 'make depend'.

Sponsored by:	EMC / Isilon Storage Division
 2016-02-24 17:20:11 +00:00
Bryan Drewery
9d8a81b4e4 DIRDEPS_BUILD: Update dependencies. 
Sponsored by:	EMC / Isilon Storage Division
 2016-02-16 02:14:30 +00:00
Alexander Motin
c85285a96b Don't check CmdSN for initial login request. 
This fixes connection errors for some initiators not starting CmdSN
from zero.

While there, fix wrong status details reported for couple errors.

MFC after:	3 days
 2016-02-12 10:58:13 +00:00
Jakub Wojciech Klama
5c734b0410 Add an additional, libucl-based configuration file parser to ctld. 
Default ctld behavior remains unchanged - libucl parser can be selected
explicitly by adding -u switch to ctld command line.

Reviewed by:	trasz
Approved by:	trasz (mentor)
MFC after:	1 month
Relnotes:	yes
Sponsored by:	iXsystems, Inc.
Differential Revision:	https://reviews.freebsd.org/D4534
 2016-02-03 15:45:13 +00:00
Bryan Drewery
b1f92fa229 META MODE: Update dependencies with 'the-lot' and add missing directories. 
This is not properly respecting WITHOUT or ARCH dependencies in target/.
Doing so requires a massive effort to rework targets/ to do so.  A
better approach will be to either include the SUBDIR Makefiles directly
and map to DIRDEPS or just dynamically lookup the SUBDIR.  These lose
the benefit of having a userland/lib, userland/libexec, etc, though and
results in a massive package.  The current implementation of targets/ is
very unmaintainable.

Currently rescue/rescue and sys/modules are still not connected.

Sponsored by:	EMC / Isilon Storage Division
 2015-12-01 05:23:19 +00:00
Edward Tomasz Napierala
05c3dfeedf Add missing error checks. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-11-14 16:18:22 +00:00
Edward Tomasz Napierala
6bfb8cccc3 Cosmetics; no functional changes. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-11-14 16:15:38 +00:00
Edward Tomasz Napierala
c2ef20fdb7 Don't try to avoid calling free(3) with NULL argument. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-11-14 16:06:01 +00:00
Alexander Motin
398290f29a Introduce portal group options in ctl.conf. 
While CTL has concept of port options, used at least for iSCSI ports now,
before this change it was impossible to set them manually.  There still
no user-configurable port options now, but I am planning to change that.
 2015-11-09 18:33:36 +00:00
Eitan Adler
463a577b27 Fix a ton of speelling errors 
arc lint is helpful

Reviewed By: allanjude, wblock, #manpages, chris@bsdjunk.com
Differential Revision: https://reviews.freebsd.org/D3337
 2015-10-21 05:37:09 +00:00
Alexander Motin
cf8f2fa24b Document CD block size of 2048. 2015-10-02 11:27:34 +00:00
Alexander Motin
6f2f92a5bf Set default block size for CD to expected 2048 bytes. 2015-10-02 11:16:46 +00:00
Alexander Motin
91be33dc78 Add to CTL initial support for CDROMs and removable devices. 
Relnotes:	yes
 2015-09-27 13:47:28 +00:00
Alexander Motin
9c887a4f86 Remove some duplicate, legacy, dead and questionable code. 2015-09-26 11:28:45 +00:00
Josh Paetzel
d7b87b89b7 Fix typo. 
Sponsored by:	iXsystems
 2015-09-25 03:46:06 +00:00
Alexander Motin
e543b3a83f Make cltd ignore HA ports. 2015-09-21 10:27:30 +00:00
Alexander Motin
3933f7b112 Add ctl-lun config option for consistency in HA setups. 2015-09-15 13:37:48 +00:00
Alexander Motin
860d3db9ce Add negotiation of iSCSIProtocolLevel to 2 (RFC7144). 
We may need to pass negotiated value to kernel level, but so far it is
not necessary, since it does not use any new features without request.
 2015-09-13 20:58:22 +00:00
Alexander Motin
828524c137 When updating port, apply only change of LUN map, not whole. 2015-09-13 15:08:06 +00:00
Alexander Motin
db7bf2baae Add two new portal group options "tag" and "foreign". 
They are going to be useful in clustered setups.
 2015-09-07 13:43:05 +00:00
Alexander Motin
a3977bea20 Allow LUN options modification via CTL_LUNREQ_MODIFY. 
Not all changes take effect, but that is a different question.
 2015-09-06 11:23:01 +00:00
Alexander Motin
c01a5fa910 Another addition to r287455. 2015-09-04 10:16:21 +00:00
Edward Tomasz Napierala
23bd2dd4a4 Use proper term in the ctld(8) and iscsid(8) man pages. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-09-03 11:43:56 +00:00
Edward Tomasz Napierala
10b5297f57 Simplify the introductory example in ctl.conf(5) down to absolute 
basics.  The more complicated cases - like how to use physical
ports - are explained later, in the "EXAMPLES" section.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-09-03 11:42:59 +00:00
Edward Tomasz Napierala
d321965424 Some random tweaks to ctl.conf(5). 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-08-24 09:33:12 +00:00
Alexander Motin
2f444d157b Drop "internal" CTL frontend. 
Its idea was to be a simple initiator and execute several commands from
kernel level, but FreeBSD never had consumer for that functionality,
while its implementation polluted many unrelated places..
 2015-08-15 13:34:38 +00:00
Alexander Motin
d7f5186022 Refactor early stages of security negotiation. 
MFC after:	2 weeks
 2015-08-08 19:04:37 +00:00
Alexander Motin
4462a6049d Remove some code duplication. 
MFC after:	1 week
 2015-08-08 16:39:28 +00:00
Edward Tomasz Napierala
424a3f57a2 Remove OpenSSL dependency from iscsid(8) and ctld(8). 
Differential Revision:	https://reviews.freebsd.org/D2866
Submitted by:	Tony Morlan <tony at scroner.com> (earlier version)
Reviewed by:	bapt@, delphij@
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-07-03 10:08:10 +00:00
Alexander Motin
0bb4b98984 Plug minor memory leak at r284765. 
Reported by:	Coverity
CID:		1308401
MFC after:	3 days
 2015-06-26 16:14:00 +00:00
Alexander Motin
d83595b2a8 Teach ctld about CTL's physical_port and virtual_port fields. 
This allows ctld to work with isp(4) virtual ports, specifying them as
isp0/1, isp0/2, etc.  There are still problems on isp(4) layer with
disabling those ports after enabling, but hopefully they can be fixed.

MFC after:	3 days
Sponsored by:	iXsystems, Inc.
 2015-06-24 15:13:27 +00:00
Edward Tomasz Napierala
a66d51f3bf Allow '@' in unquoted strings, such as with the "path" statement. Note 
that one can use any character they like by using double quotes.

PR:		200895
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
 2015-06-18 10:17:47 +00:00
Alexander Motin
f249b52d9a Fix bug in r278331: unlike some other options MaxRecvDataSegmentLength 
is not negotiated as minimum, but only reported by sides to each other.

MFC after:	1 week
 2015-06-02 01:47:12 +00:00
Edward Tomasz Napierala
b853c718a9 Advertise ctlstat(8) a little better. 
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
 2015-05-22 11:59:37 +00:00
Edward Tomasz Napierala
aa32b5e076 Make setproctitle(3) work in Capsicum capability mode. This makes 
ctld(8) child processes to indicate initiator address and name in
their titles, similar to what iscsid(8) child processes do.

PR:		181352
Differential Revision:	https://reviews.freebsd.org/D2363
Reviewed by:	rwatson@, mjg@
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-04-27 11:18:16 +00:00
Edward Tomasz Napierala
6775608bea Add hint about "volmode=dev" to ctl.conf(5). 
Differential Revision:	https://reviews.freebsd.org/D2328
Reviewed by:	allanjude@, bcr@
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-04-21 09:11:28 +00:00
Xin LI
a7c4ad3926 Eliminate unused headers. 2015-04-14 18:13:55 +00:00
Alexander Motin
83dd77c3c1 Make ctld to not exit on ECONNABORTED on accept(). 
That is not really an error for the main process.

MFC after:	1 week
Sponsored by:	iXsystems, Inc.
 2015-04-06 18:56:02 +00:00
Josh Paetzel
7c924aae61 Fix thinko/copypaste error. 
When checking the length of the mutual secret password the variable for
the secret password was used by mistake.  This resulted in ctld never
warning about the length of the mutual secret being wrong even if it was.

MFC after:	3 days
Sponsored by:	iXsystems
 2015-04-04 20:55:47 +00:00
Alexander Motin
3bac1be816 Add example configuration for FibreChannel ports. 
MFC after:	1 week
 2015-03-04 14:30:09 +00:00
Alexander Motin
aadf439b22 If target name starts with "naa.", set it as WWNN for CTL port. 
MFC after:	1 week
Sponsored by:	iXsystems, Inc.
 2015-03-04 14:12:38 +00:00
Alexander Motin
e9b7390bb2 Fix handling of queued text and logout requests. 
While it may have little sense, text and logout requests can be queued.
If they are, they consume cmdsn, so we should increment our conn_cmdsn.

MFC after:	1 week
 2015-03-04 12:12:46 +00:00
Edward Tomasz Napierala
a9d7821075 Move the "offload" clause from the target section to portal-group 
section; it makes more sense there.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-02-28 12:02:32 +00:00
Edward Tomasz Napierala
f584f51d96 Add missing error check. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-02-26 09:08:48 +00:00
Alexander Motin
678b68798f Fix memory leak on incorrect initiator portal. 
Submitted by:	Dmitry Luhtionov <dmitryluhtionov@gmail.com>
MFC after:	3 days
 2015-02-25 10:10:40 +00:00
Alexander Motin
16fa28094c Add checks for malloc() failures. 
Submitted by:	Dmitry Luhtionov <dmitryluhtionov@gmail.com>
MFC after:	3 days
 2015-02-25 10:07:39 +00:00