Sam Leffler
af2b2a7331
Redo locking for proper SMP operation:
...
o replace driver-global lock with three locks: one for the handling of mcr1
operations, one for handling of mcr2 operations, and one for the mcr1
free list
o mark the interrupt handler MPSAFE
o don't use locking on detach; disabling interrupts is sufficient (I think)
2003-06-02 23:32:03 +00:00
Poul-Henning Kamp
0f557e0ac0
Further devilification of CCD:
...
Change the list interface to simplify things.
Remove old list ioctls which bogusly exported the softc to userland.
Move the softc and associated structures from the public header to
the source file.
2003-06-02 21:29:04 +00:00
Poul-Henning Kamp
189337d81f
Begin deevilification of CCD:
...
Make CCD a GEOM class.
For now only use this for implementing a OAM config method which
can return a list of configured CCD devices in the format which
"ccdconfig -g[v]" would normally output.
2003-06-02 20:50:03 +00:00
David E. O'Brien
006124d811
Use __FBSDID().
2003-06-02 16:32:55 +00:00
Maxim Konovalov
b0af6a7be5
Remove unused #ifdef BRIDGE.
...
Reviewed by: nyan
2003-06-02 08:36:18 +00:00
Mike Silbersack
1104779b70
Replace if_fxp's handrolled defrag function with m_defrag.
...
No actual bug with the existing code, just tidying things up.
Submitted by: hmp
2003-06-02 05:16:42 +00:00
Maxime Henrion
1edc4c46b8
Change a :
...
bzero(ptr, sizeof(DC_RXLEN * 5));
which should obviously be:
bzero(ptr, DC_RXLEN * 5);
Looks like this bug may have reduced the effectiveness of the
workaround for the hardware bug in the PNIC chips.
MFC after: 1 week
2003-06-01 22:09:12 +00:00
Maxime Henrion
0934f18afb
- Style(9) fixes, most notably :
...
o Remove register keyword
o ANSIfy prototypes
o Remove "return;" at the end of void functions
o Remove trailing spaces
o Don't align local variables with tabs and reorder them
o Don't use /* FOO */ at the end of a #ifdef FOO block if
it's a small block
- Other non-functional changes :
o 6 -> ETHER_ADDR_LEN
o Don't initialize if_output; ether_ifattach() does it for us
2003-06-01 19:26:34 +00:00
Matt Jacob
d8f9e010d2
Restore parentheses removed inappropriately in last commit.
2003-06-01 19:01:01 +00:00
Dag-Erling Smørgrav
f834a1168c
Add (but do not connect) a half-finished driver for Aureal Vortex cards.
...
The mixer works, pcm support is half done.
2003-06-01 11:58:46 +00:00
Poul-Henning Kamp
b3c481ae1a
Remove break after return.
...
Add XXX comment where intent is unclear.
Found by: FlexeLint
2003-06-01 09:27:33 +00:00
Poul-Henning Kamp
b44f808797
Don't leak "barlist" allocation on failure.
...
Found by: FlexeLint
2003-06-01 09:24:17 +00:00
Juli Mallett
b0327095f6
Use SC_NO_CUTPASTE to protect cutpaste variables correctly, fixing the
...
-Werror build with such option, but not other combinations. LINT
misses this because syscons knobs in LINT turn off a lot of code.
Reviewed by: marcel (some time ago)
2003-06-01 04:42:14 +00:00
Poul-Henning Kamp
a3e7d3f16f
wrap macro in do {...} while(0)
2003-05-31 21:11:51 +00:00
Poul-Henning Kamp
35e1694a4d
Remove unused variable(s).
...
Add XXX comment where intent is unclear.
Found by: FlexeLint
2003-05-31 20:43:17 +00:00
Poul-Henning Kamp
bb0b8a23c0
Remove unused variable(s).
...
Found by: FlexeLint
2003-05-31 20:42:24 +00:00
Poul-Henning Kamp
00999c80d8
Eliminate mostly unused local variable.
...
Found by: FlexeLint
2003-05-31 20:41:52 +00:00
Poul-Henning Kamp
d2f30d92a7
Add /* FALLTHROUGH */
...
Remove break after return
Found by: FlexeLint
2003-05-31 20:41:08 +00:00
Poul-Henning Kamp
25371920a0
Fix indentation
...
Found by: FlexeLint
2003-05-31 20:40:12 +00:00
Poul-Henning Kamp
6f75979695
Remove unused variable(s).
...
Add /* FALLTHROUGH */
Found by: FlexeLint
2003-05-31 20:39:28 +00:00
Poul-Henning Kamp
4738f8c1a8
Remove return after goto.
...
Remove break after return;
Found by: FlexeLint
2003-05-31 20:35:32 +00:00
Poul-Henning Kamp
60db3b9e60
Remove unused variable(s).
...
Remove break after return;
Found by: FlexeLint
2003-05-31 20:34:36 +00:00
Poul-Henning Kamp
66f7a83274
Put definition of struct svr4_sockcache_entry in a .h file rather than
...
having two independent definitions in two .c files.
Fiddle surrounding details to match.
Found by: FlexeLint
2003-05-31 20:33:18 +00:00
Poul-Henning Kamp
670966596b
Remove unused variable(s).
...
Found by: FlexeLint
2003-05-31 20:29:34 +00:00
Poul-Henning Kamp
d1043f6d6a
Remove break after return
...
Found by: FlexeLint
2003-05-31 20:28:21 +00:00
Poul-Henning Kamp
85dc30cf82
Remove unused variable(s).
...
Put XXX comment where intent is unclear.
Found by: FlexeLint
2003-05-31 20:27:42 +00:00
Poul-Henning Kamp
7d4220518e
Remove break after return;
...
Found by: FlexeLint
2003-05-31 20:24:30 +00:00
Poul-Henning Kamp
f22cfda31c
Remove break after return
...
Found by: FlexeLint
2003-05-31 19:59:29 +00:00
Poul-Henning Kamp
9c96882e80
Remove unused variables.
...
Found by: FlexeLint
2003-05-31 19:58:45 +00:00
Poul-Henning Kamp
1000b87f2a
Remove now unused pointer to etherheader.
...
Found by: FlexeLint
2003-05-31 19:56:35 +00:00
Poul-Henning Kamp
a0fb4cf18d
Remove unused variables
...
Add /* FALLTHROUGH */
Found by: FlexeLint
2003-05-31 19:49:49 +00:00
Poul-Henning Kamp
19ca58475e
Remove unnecessary breaks.
...
Remove unused variables.
Add XXX comment where a break may be missing. [lxtphy.c]
Found by: FlexeLint
2003-05-31 19:48:33 +00:00
Poul-Henning Kamp
5a87a6f702
Move some FALLTHROUGH comments so they work.
...
Fix indentation error.
Make boardid string long enough.
Remove unused variable.
Found by: FlexeLint
2003-05-31 19:46:58 +00:00
Poul-Henning Kamp
16cef37ea3
Don't define memcpy() to bcopy() and in particular not memset() to
...
bzero() when we have them all already.
Found by: FlexeLint
2003-05-31 19:38:43 +00:00
Poul-Henning Kamp
b2bf0c7f48
Fix indentation.
...
Found by: FlexeLint
2003-05-31 19:38:00 +00:00
Poul-Henning Kamp
5578b9263b
Do not define memset() to bzero(). We have a memset().
...
Found by: FlexeLint
2003-05-31 19:31:46 +00:00
Poul-Henning Kamp
78b52202d0
Fix indentation.
...
Found by: FlexeLint
2003-05-31 19:02:20 +00:00
Poul-Henning Kamp
01bfa91fa2
Fix off-by-one error in range check of VC index.
...
Found by: FlexeLint
2003-05-31 19:01:08 +00:00
Poul-Henning Kamp
89e3693051
Remove extra ';'
...
Found by: FlexeLint
2003-05-31 18:57:41 +00:00
Poul-Henning Kamp
d6b602d4b2
Remove unused variable.
...
Found by: FlexeLint
2003-05-31 18:55:18 +00:00
Poul-Henning Kamp
c7b24d7dcd
Remove unused variable.
...
Found by: FlexeLint
2003-05-31 18:45:32 +00:00
Poul-Henning Kamp
777d1b3990
Fix off-by-one error in drive number check.
...
Don't return(foo(...)) in function returning void.
Found by: FlexeLint
2003-05-31 18:41:09 +00:00
Poul-Henning Kamp
0623afde6f
Remove extra unused variable.
...
Found by: FlexeLint
2003-05-31 18:39:29 +00:00
Poul-Henning Kamp
9d4b1fa40e
Remove extra ';'
...
Found by: FlexeLint
2003-05-31 18:37:30 +00:00
Poul-Henning Kamp
da507a2181
Fix \ alignment in macro.
...
Remove breaks after return.
Remove unused variable.
Found by: FlexeLint
2003-05-31 18:21:40 +00:00
Poul-Henning Kamp
f075585f67
Remove the G_CLASS_INITIALIZER, we do not need it anymore.
2003-05-31 16:59:27 +00:00
Poul-Henning Kamp
26028fee6f
Don't use return(foo(...)); in function returning void.
...
Found by: FlexeLint
2003-05-31 16:51:41 +00:00
Poul-Henning Kamp
17a1391990
The IO_NOWDRAIN and B_NOWDRAIN hacks are no longer needed to prevent
...
deadlocks with vnode backed md(4) devices because md now uses a
kthread to run the bio requests instead of doing it directly from
the bio down path.
2003-05-31 16:42:45 +00:00
Peter Wemm
151cd71608
Add the MD ifdefs for amd64 to point to the IO space bustag/handle.
...
Approved by: re ("safe" amd64 support)
2003-05-31 06:45:28 +00:00
Scott Long
9d5be300d3
Add support for the upcoming 2410SA card.
...
Approved by: re (telecon)
2003-05-30 09:22:19 +00:00