Commit Graph

52 Commits

Author SHA1 Message Date
Ulrich Spörlein
3df5ecac8c Spelling fixes for usr.sbin/ 2011-12-30 10:58:14 +00:00
Eitan Adler
520374b5aa - Remove extraneous null ptr deref checks
- Fix memory leak

Submitted by:	Slono Slono <slonoman2011@yandex.ru>
Approved by:	jhb
MFC after:	1 week
2011-12-21 20:27:41 +00:00
Ed Maste
0737626a7f Quiet clang warnings by using literal format strings for printf-like
functions.
2011-01-04 02:52:22 +00:00
Kevin Lo
f55df2a221 Closing fd when it's done
Reviewed by:	sbruno
2010-12-09 08:36:23 +00:00
Joel Dahl
d4352d2928 Spelling fixes. 2010-08-01 09:37:36 +00:00
Ulrich Spörlein
47e1a877c5 Always assign WARNS using ?=
- fix some nearby style bugs
- include Makefile.inc where it makes sense and reduces duplication

Approved by:	ed (co-mentor)
2010-03-02 16:58:04 +00:00
Sean Bruno
cde9186f93 Remove reference to phy_delay from fwcontrol. Thanks for the catch!
Submitted by:	Giorgos Keramidas <keramida@ceid.upatras.gr>
MFC after:	2 weeks
2009-02-17 23:56:16 +00:00
Sean Bruno
e627b033dc Begin basic improvements to fwcontrol in the area of handling
video streams from cameras.

This patch changes the displayed timer to a time stamp and corrects
one or two mishandled errors.

Submitted by:	imp
2009-02-02 21:05:12 +00:00
Warner Losh
96747dc015 Add fd = -1 after close when we detect the format so that subsequent
open_dev will reopen the device.
2009-01-02 08:21:21 +00:00
Sean Bruno
c1de48a3d2 Reviewed by: (Dieter)freebsd@sopwith.solgatos.com
Approved by:	slong scottl@samsco.org
MFC after:	2 weeks

Final cleanup of fwcontrol.
  NetBSD compatibility
  Cleanup errors in usage() display
  Finish up error handling via errx/warnx
  Generate error on unparsed command line syntax
  Change device(devbase) to open into the form /dev/fwX.X
2008-12-12 18:17:23 +00:00
Daniel Gerzo
2cdb71a94a Sweep this man page a bit:
- new sentence = new line
- use .Dq macro to quote words
- some minor rewording

MFC after:	2 weeks
2008-09-11 22:11:41 +00:00
Sean Bruno
7f1b527c00 Beginning of overhaul of fwcontrol:
-  Documentation of send_phy_config()
-  cleanup of malloc's() and added error checking throughout
-  new capability to iterate over multiple firewire buses
-  update usage() display
-  cleanup command line parsing to allow out of order switches
-  cleanup command line parsing to allow multiple switches per invocation
-  cleanup grammar of man page a bit
-  add some ranges to the man page to indicate what values are valid

Since fwcontrol's code is the same across 6/7/head this can be
applied to all branches after the MFC period.

Reviewed by:	Dieter freebsd@sopwith.solgatos.com
Approved by:	mentor Scott scottl@samsco.org
MFC after:	60 days
2008-09-10 18:09:52 +00:00
Hidetoshi Shimokawa
302176c71f - add '-f' option to force root node.
- fix byte order in read_write_quad()
- show hostnames in the list
- fix typo in manpage

MFC after: 1 week
2008-03-05 01:30:48 +00:00
Christian Brueffer
0297fef065 Remove dublicate .Pp, sort SEE ALSO. 2007-10-31 05:59:17 +00:00
Giorgos Keramidas
e6039c36f0 Whitespace-only change: trim EOL spaces. 2007-10-30 16:08:06 +00:00
Giorgos Keramidas
9aeec3c7db mdoc warning fix: delete spurious empty line.
MFC after:	3 days
2007-10-30 16:06:48 +00:00
Hidetoshi Shimokawa
072d350754 Increase buffer size of DV stream to prevent buffer
overrun caused by long blocking of file I/O (i.e. zfs).

MFC after: 3 days
2007-06-17 10:20:55 +00:00
Yaroslav Tykhiy
9b3d1b0253 Fix a group of typos:
preceed -> precede,
preceeded -> preceded,
preceeding -> preceding.

Submitted by:	Andre Guibert de Bruet <andy@siliconlandmark.com>
2006-12-29 13:08:46 +00:00
Warner Losh
6d815a7d8c Add MPEG2-TS/HDV support to fwcontrol.
Submitted by: Petr Holub" <hopet@ics.muni.cz>
Clean up by: mi@
Pr: 98134
2006-10-26 22:33:38 +00:00
Philippe Charnier
3fe9d89a62 Remove unused variables. Shorten the path to a WARNS=6 compliance. 2005-05-20 12:50:47 +00:00
Ruslan Ermilov
59a3c79da6 Sort sections. 2005-01-18 20:02:45 +00:00
Ruslan Ermilov
1a74e6a157 Scheduled mdoc(7) sweep. 2005-01-11 11:47:22 +00:00
Christian Brueffer
eb1b84fe40 - Xref fwip(4)
- bump .Dd

MFC after:	3 days
2004-12-14 20:44:37 +00:00
Hidetoshi Shimokawa
f62482315a Add usage of -m option. 2004-10-29 01:24:32 +00:00
Hidetoshi Shimokawa
1be7387c03 Add -m option, set default fwmem target. 2004-10-23 23:28:08 +00:00
Ruslan Ermilov
800b8436b0 Nit. 2004-06-04 19:23:39 +00:00
Brooks Davis
cb5df0b27b Use new eui64(3) functions to print EUI-64s and to allow access to nodes
by EUI-64 and name.

Reviewed by:	simokawa
2004-05-26 22:59:55 +00:00
Doug Rabson
3d7b1b4143 Don't crash if the CROM is all zeros. 2004-05-23 10:06:33 +00:00
Christian Brueffer
0270455437 o grammar fixes
o wordsmithing
o s/isochronus/isochronous/

MFC after:	5 days
2003-12-17 10:14:11 +00:00
Hidetoshi Shimokawa
cfa42d3692 Add '0x' in front of EUI64 to avoid confusion. 2003-10-22 07:23:27 +00:00
Hidetoshi Shimokawa
a8587980d8 Add -p option to dump phy registers. 2003-09-25 09:33:16 +00:00
Hidetoshi Shimokawa
abd538f249 - Use /dev/fwX.Y rather than /dev/fwX.
- Add option -u to specify bus number.
- Try to open the device only if it's necessary.
2003-08-05 03:26:14 +00:00
Hidetoshi Shimokawa
cf00a0dab5 - Allow retrieval of local Configuration ROM.
- Clear Configuration ROM buffer in advance for '-d' option.
2003-07-12 09:36:53 +00:00
Hidetoshi Shimokawa
c6747f0f42 Decode bus_info block. 2003-06-10 02:32:22 +00:00
Ruslan Ermilov
f937c268cf Assorted mdoc(7) fixes. 2003-06-02 11:19:24 +00:00
Ruslan Ermilov
07958659ba Nitpicking.
Approved by:	re (blanket)
2003-05-22 11:54:53 +00:00
Hidetoshi Shimokawa
b92d9b2bfd Add description of '-o' and '-s'. 2003-05-01 06:33:13 +00:00
Hidetoshi Shimokawa
6f9c571fe3 Set include path. 2003-04-30 03:39:25 +00:00
Hidetoshi Shimokawa
5193feb69e Free asyreq.
Submitted by: ryuchi@ryuchi.org
2003-04-30 03:38:07 +00:00
Hidetoshi Shimokawa
d1f7bcb5a2 Add functions for sending a link-on packet and a RESET_START request. 2003-04-29 13:49:21 +00:00
Hidetoshi Shimokawa
ee724a65cb Use fwcrom.c in /sys/dev/firewire. 2003-04-26 16:46:59 +00:00
Hidetoshi Shimokawa
77ee030b5f MFp4(simokawa_firewire):
Many internal structure changes for the FireWire driver.

- Compute CRC in CROM parsing.
- Add support for configuration ROM build.
- Simplify dummy buffer handling.
- busdma conversion
- Use swi_taskqueue_giant for -current.  Mark the interrupt routine as MPSAFE.
- AR buffer handling.
	Don't reallocate AR buffer but just recycle it.
	Don't malloc and copy per packet in fwohci_arcv().
	Pass packet to fw_rcv() using iovec.
	Application must prepare receiving buffer in advance.
- Change fw_bind API so that application should pre-allocate xfer structure.
- Add fw_xfer_unload() for recycling struct fw_xfer.
- Add post_busreset hook
- Remove unused 'sub' and 'act_type' in struct fw_xfer.
- Remove npacket from struct fw_bulkxfer.
- Don't call back handlers in fwochi_arcv() if the packet has
	not drained in AT queue
- Make firewire works on big endian platform.
- Use native endian for packet header and remove unnecessary ntohX/htonX.
- Remove FWXFERQ_PACKET mode.  We don't use it anymore.
- Remove unnecessary restriction of FWSTMAXCHUNK.
- Don't set root node for phy config packet if the root node is
	not cycle master capable but set myself for root node.
	We should be the root node after next bus reset.

	Spotted by: Yoshihiro Tabira <tabira@scd.mei.co.jp>
- Improve self id handling

Tested on: i386, sparc64 and i386 with forced bounce buffer
2003-04-17 03:38:03 +00:00
Hidetoshi Shimokawa
2932d7d58b - Detect PAL by CIP header rather than the DSF bit in the DV header.
Some DVcam(ex. Panasonic NV-DS1 DV camcorder) doesn't seems to set
	this bit even if it's for PAL. Fix the DSF bit for such cases so that
	we can send back the stream to the DVcam without problem.
Problem Reported by: Richard Tobin <richard@cogsci.ed.ac.uk>

- Make the number of bulkxfer packets(NPACKET_T) and the number of packets
	write at once(TNBUF) to be different values.
	I observe some block noise for large TNBUF.
- Show the detection of NTSC or PAL.
- Pad with 0xff rather than 0x00 for broken frames.
- Bzero hdr[0].
- Remove unused code.
2003-02-19 01:14:52 +00:00
Hidetoshi Shimokawa
e6aaafcd79 Improve device listing. 2003-02-09 07:26:48 +00:00
Hidetoshi Shimokawa
91b4ea0cc7 Improve alignment in printf(). 2003-01-30 03:46:48 +00:00
Hidetoshi Shimokawa
013490c5e0 - Search free device node to open. (fwcontrol.c)
- Exploit multiple packets read/write for DV stream. (fwdv.c)
- Add reference to libdv in the ports collection. (fwcontrol.8)
2003-01-28 17:00:23 +00:00
Hidetoshi Shimokawa
c547b896f5 Change API of FW_GDEVLST ioctl.
- include information about itself.
- define struct fw_devinfo and use it in struct fw_devlstreq.
- unify EUI64 representation using struct fw_eui64.
2003-01-25 14:47:33 +00:00
Hidetoshi Shimokawa
8604e72a9f Use stderr for message output. 2003-01-24 03:40:36 +00:00
Hidetoshi Shimokawa
937bcaa881 Merge DV(Digital Video) support. 2003-01-23 16:10:12 +00:00
Hidetoshi Shimokawa
bce5729a9d - Remove speed_map API because speed_map is obsoleted by 1394a.
- Add definition of OHCI_HCC_BIBIV in fwohcireg.h.
2003-01-04 16:03:50 +00:00