Commit Graph

11 Commits

Author SHA1 Message Date
Li-Wen Hsu
be5f9a5a5d Fix typo & build
Approved by:	kevlo
2018-01-05 08:29:32 +00:00
Warner Losh
5066eaeb75 Add a number of sanity checks to the data that we're handling from the
CIS. Coverity has tagged it as tainted. While this data is more
trusted than your average data, we still need to do some basic
validation on it. Check ioctl return value to ensure we switch memory
targets between common and attribute as well as the lseek.

CID: 1210464, 1006640, 1006868, 1007292, 1009091, 1009822, 1009824
2018-01-05 07:09:40 +00:00
Pedro F. Giffuni
1de7b4b805 various: general adoption of SPDX licensing ID tags.
Mainly focus on files that use BSD 2-Clause license, however the tool I
was using misidentified many licenses so this was mostly a manual - error
prone - task.

The Software Package Data Exchange (SPDX) group provides a specification
to make it easier for automated tools to detect and summarize well known
opensource licenses. We are gradually adopting the specification, noting
that the tags are considered only advisory and do not, in any way,
superceed or replace the license texts.

No functional change intended.
2017-11-27 15:37:16 +00:00
Warner Losh
f7911ae51d Move sys/pccard/*.h here. 2009-02-15 03:21:37 +00:00
Warner Losh
6b88fc62e1 Fix check for link target so we don't print cardbus CIS information twice.
Also, eliminate some magic constants and replace them with values from cis.h.
2008-11-20 08:30:15 +00:00
Warner Losh
8a1dbe91d4 Restore now-useless ioctl as a roadmap. The original dumpcis code
assumed it had to toggle between attribute and common memory in the
cards.  The kernel is supposed to cope with that automatically and
give us a tuple list.  However, there's a number of details of how
that happens that's currently, ummm, magical and/or not implemented
for 16-bit PC Cards that have CIS_LONGLINK_C tuples in them (eg, mix
both attribute memory and common memory).  Also, CIS_LOGNLINK_A
entries might not be handled completely correctly either, since there
can be gaps in the attribute vs common stuff.

All this will need to be corrected in the kernel.  Once it is
corrected, dumpcis can be made even simpler in some ways, a little
more complicated in others once an API for presentation of CIS to
userland in these weird cases is settled upon.
2008-11-20 08:20:53 +00:00
Warner Losh
cc4870f1e6 More dead code removal. 2008-11-20 08:14:14 +00:00
Warner Losh
2d134dead2 The original programs that this code was lifted from (pccardd and
pccardc) parsed data to make decisions about stuff related to card
configuration.

The purely CIS dumping aspect of this program obviates the need for
such parsing.  Save some space and don't parse the data anymore for
configuration purposes.  Just parse it to print an interpreatation of
it.
2008-11-20 08:12:26 +00:00
Warner Losh
199493b917 dump() really is unused, so retire it. 2008-11-20 03:34:36 +00:00
Warner Losh
c1d393d207 make this warns=5 clean 2008-11-17 22:46:29 +00:00
Warner Losh
0738c00eb5 Move dumpcis to its own directory, start to decouple from the
pccardc/pccardd history.
2008-11-17 22:19:19 +00:00