Matthew Ahrens 02dc43bc46 OpenZFS 8378 - crash due to bp in-memory modification of nopwrite block ...

Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Ported-by: Giuseppe Di Natale <dinatale2@llnl.gov>

The problem is that zfs_get_data() supplies a stale zgd_bp to
dmu_sync(), which we then nopwrite against.
zfs_get_data() doesn't hold any DMU-related locks, so after it
copies db_blkptr to zgd_bp, dbuf_write_ready() could change
db_blkptr, and dbuf_write_done() could remove the dirty record.
dmu_sync() then sees the stale BP and that the dbuf it not dirty,
so it is eligible for nop-writing.
The fix is for dmu_sync() to copy db_blkptr to zgd_bp after
acquiring the db_mtx. We could still see a stale db_blkptr,
but if it is stale then the dirty record will still exist and
thus we won't attempt to nopwrite.

OpenZFS-issue: https://www.illumos.org/issues/8378
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/3127742
Closes #6293

2017-07-04 15:41:24 -07:00

..

abd.c

minor improvement to abd_free_pages()

2017-05-02 10:06:18 -07:00

arc.c

OpenZFS 7910 - l2arc_write_buffers() may write beyond target_sz

2017-07-04 15:28:58 -07:00

blkptr.c

DLPX-44812 integrate EP-220 large memory scalability

2016-11-29 14:34:27 -08:00

bplist.c

Change KM_PUSHPAGE -> KM_SLEEP

2015-01-16 14:41:26 -08:00

bpobj.c

Don't dirty bpobj if it has no entries

2017-05-26 11:42:10 -07:00

bptree.c

OpenZFS 7082 - bptree_iterate() passes wrong args to zfs_dbgmsg()

2017-01-17 14:49:24 -08:00

bqueue.c

Call cv_signal() with mutex held

2017-06-26 14:36:49 -07:00

dbuf_stats.c

OpenZFS 6950 - ARC should cache compressed data

2016-09-13 09:58:33 -07:00

dbuf.c

Clean up large dnode code

2017-06-29 10:18:03 -07:00

ddt_zap.c

Change KM_PUSHPAGE -> KM_SLEEP

2015-01-16 14:41:26 -08:00

ddt.c

Cache ddt_get_dedup_dspace() value if there was no ddt changes

2016-12-02 16:59:35 -07:00

dmu_diff.c

OpenZFS 6950 - ARC should cache compressed data

2016-09-13 09:58:33 -07:00

dmu_object.c

Add kpreempt_disable/enable around CPU_SEQID uses

2017-06-19 09:43:16 -07:00

dmu_objset.c

OpenZFS 8199 - multi-threaded dmu_object_alloc()

2017-06-09 09:43:26 -07:00

dmu_send.c

OpenZFS 8056 - zfs send size estimate is inaccurate for some zvols

2017-06-09 09:46:14 -07:00

dmu_traverse.c

Add TASKQID_INVALID

2016-11-02 12:14:45 -07:00

dmu_tx.c

OpenZFS 8063 - verify that we do not attempt to access inactive txg

2017-05-10 13:52:22 -04:00

dmu_zfetch.c

Use cstyle -cpP in make cstyle check

2016-12-12 10:46:26 -08:00

dmu.c

OpenZFS 8378 - crash due to bp in-memory modification of nopwrite block

2017-07-04 15:41:24 -07:00

dnode_sync.c

OpenZFS 7968 - multi-threaded spa_sync()

2017-03-20 18:36:00 -07:00

dnode.c

Clean up large dnode code

2017-06-29 10:18:03 -07:00

dsl_bookmark.c

OpenZFS 8377 - Panic in bookmark deletion

2017-06-30 11:11:01 -07:00

dsl_dataset.c

OpenZFS 7600 - zfs rollback should pass target snapshot to kernel

2017-07-04 15:29:52 -07:00

dsl_deadlist.c

Add missing *_destroy/*_fini calls

2017-05-04 19:26:28 -04:00

dsl_deleg.c

Performance optimization of AVL tree comparator functions

2016-08-31 14:35:34 -07:00

dsl_destroy.c

OpenZFS 7254 - ztest failed assertion in ztest_dataset_dirobj_verify: dirobjs + 1 == usedobjs

2017-01-27 11:43:42 -08:00

dsl_dir.c

Reduce stack usage of dsl_dir_tempreserve_impl

2017-06-12 11:41:03 -07:00

dsl_pool.c

OpenZFS 8063 - verify that we do not attempt to access inactive txg

2017-05-10 13:52:22 -04:00

dsl_prop.c

Fix dsl_props_set_sync_impl to work with nested nvlist

2016-12-20 18:46:59 -08:00

dsl_scan.c

OpenZFS 8070 - Add some ZFS comments

2017-05-25 17:15:06 -07:00

dsl_synctask.c

Illumos 4951 - ZFS administrative commands should use reserved space

2015-05-04 09:41:10 -07:00

dsl_userhold.c

OpenZFS 6314 - buffer overflow in dsl_dataset_name

2016-06-28 13:47:03 -07:00

edonr_zfs.c

DLPX-44812 integrate EP-220 large memory scalability

2016-11-29 14:34:27 -08:00

fm.c

Use cstyle -cpP in make cstyle check

2016-12-12 10:46:26 -08:00

gzip.c

GZIP compression offloading with QAT accelerator

2017-03-22 17:58:47 -07:00

lz4.c

Fix LZ4_uncompress_unknownOutputSize caused panic

2017-05-19 13:45:46 -07:00

lzjb.c

Change KM_PUSHPAGE -> KM_SLEEP

2015-01-16 14:41:26 -08:00

Makefile.in

GZIP compression offloading with QAT accelerator

2017-03-22 17:58:47 -07:00

metaslab.c

OpenZFS 8023 - Panic destroying a metaslab deferred range tree

2017-04-09 16:12:35 -07:00

multilist.c

OpenZFS 7968 - multi-threaded spa_sync()

2017-03-20 18:36:00 -07:00

pathname.c

Add pn_alloc()/pn_free() functions

2016-04-21 09:49:25 -07:00

policy.c

codebase style improvements for OpenZFS 6459 port

2017-01-22 13:25:40 -08:00

qat_compress.c

Change U16 to U32 due to atomic_inc_32_nv

2017-04-25 17:41:58 -07:00

qat_compress.h

GZIP compression offloading with QAT accelerator

2017-03-22 17:58:47 -07:00

range_tree.c

Performance optimization of AVL tree comparator functions

2016-08-31 14:35:34 -07:00

refcount.c

Linux 4.11 compat: avoid refcount_t name conflict

2017-02-28 16:10:18 -08:00

rrwlock.c

Fix spelling

2017-01-03 11:31:18 -06:00

sa.c

OpenZFS 8061 - sa_find_idx_tab can be declared more type-safely

2017-04-14 11:11:28 -07:00

sha256.c

DLPX-44812 integrate EP-220 large memory scalability

2016-11-29 14:34:27 -08:00

skein_zfs.c

DLPX-44812 integrate EP-220 large memory scalability

2016-11-29 14:34:27 -08:00

spa_boot.c

Add linux kernel module support

2010-08-31 13:41:58 -07:00

spa_config.c

Fix spelling

2017-01-03 11:31:18 -06:00

spa_errlog.c

Illumos 4914 - zfs on-disk bookmark structure should be named *_phys_t

2014-08-06 14:48:41 -07:00

spa_history.c

Fix indefinite article

2016-08-11 11:23:49 -07:00

spa_misc.c

Force fault a vdev with 'zpool offline -f'

2017-05-19 12:30:16 -07:00

spa_stats.c

Fix spelling

2017-01-03 11:31:18 -06:00

spa.c

Fix import wrong spare/l2 device when path change

2017-06-01 06:39:42 -07:00

space_map.c

OpenZFS 8023 - Panic destroying a metaslab deferred range tree

2017-04-09 16:12:35 -07:00

space_reftree.c

OpenZFS 6328 - Fix cstyle errors in zfs codebase

2017-01-12 09:42:11 -08:00

trace.c

OpenZFS 6531 - Provide mechanism to artificially limit disk performance

2016-05-26 10:11:51 -07:00

txg.c

OpenZFS 8063 - verify that we do not attempt to access inactive txg

2017-05-10 13:52:22 -04:00

uberblock.c

Illumos 5347 - idle pool may run itself out of space

2015-07-14 10:35:21 -07:00

unique.c

Performance optimization of AVL tree comparator functions

2016-08-31 14:35:34 -07:00

vdev_cache.c

Fix wrong offset args in vdev_cache_write

2017-03-28 11:06:22 -07:00

vdev_disk.c

Skip spurious resilver IO on raidz vdev

2017-05-12 17:28:03 -07:00

vdev_file.c

Skip spurious resilver IO on raidz vdev

2017-05-12 17:28:03 -07:00

vdev_label.c

Force fault a vdev with 'zpool offline -f'

2017-05-19 12:30:16 -07:00

vdev_mirror.c

Skip spurious resilver IO on raidz vdev

2017-05-12 17:28:03 -07:00

vdev_missing.c

Skip spurious resilver IO on raidz vdev

2017-05-12 17:28:03 -07:00

vdev_queue.c

Cap maximum aggregate IO size

2017-06-27 10:09:16 -07:00

vdev_raidz_math_aarch64_neon_common.h

ABD raidz NEON support

2016-11-29 14:34:33 -08:00

vdev_raidz_math_aarch64_neon.c

codebase style improvements for OpenZFS 6459 port

2017-01-22 13:25:40 -08:00

vdev_raidz_math_aarch64_neonx2.c

ABD raidz NEON support

2016-11-29 14:34:33 -08:00

vdev_raidz_math_avx2.c

ABD raidz avx512f support

2016-11-29 14:34:33 -08:00

vdev_raidz_math_avx512bw.c

ABD: Adapt avx512bw raidz assembly

2016-12-15 17:31:33 -08:00

vdev_raidz_math_avx512f.c

Use cstyle -cpP in make cstyle check

2016-12-12 10:46:26 -08:00

vdev_raidz_math_impl.h

codebase style improvements for OpenZFS 6459 port

2017-01-22 13:25:40 -08:00

vdev_raidz_math_scalar.c

ABD Vectorized raidz

2016-11-29 14:34:33 -08:00

vdev_raidz_math_sse2.c

ABD raidz avx512f support

2016-11-29 14:34:33 -08:00

vdev_raidz_math_ssse3.c

codebase style improvements for OpenZFS 6459 port

2017-01-22 13:25:40 -08:00

vdev_raidz_math.c

codebase style improvements for OpenZFS 6459 port

2017-01-22 13:25:40 -08:00

vdev_raidz.c

Skip spurious resilver IO on raidz vdev

2017-05-12 17:28:03 -07:00

vdev_root.c

Skip spurious resilver IO on raidz vdev

2017-05-12 17:28:03 -07:00

vdev.c

Force fault a vdev with 'zpool offline -f'

2017-05-19 12:30:16 -07:00

zap_leaf.c

OpenZFS 1300 - filename normalization doesn't work for removes

2017-02-02 14:13:41 -08:00

zap_micro.c

Add missing *_destroy/*_fini calls

2017-05-04 19:26:28 -04:00

zap.c

Add missing *_destroy/*_fini calls

2017-05-04 19:26:28 -04:00

zfeature_common.c

OpenZFS 2932 - support crash dumps to raidz, etc. pools

2017-04-10 10:24:17 -07:00

zfeature.c

OpenZFS 6328 - Fix cstyle errors in zfs codebase

2017-01-12 09:42:11 -08:00

zfs_acl.c

Rename zfs_sb_t -> zfsvfs_t

2017-03-10 09:51:33 -08:00

zfs_byteswap.c

Add linux kernel module support

2010-08-31 13:41:58 -07:00

zfs_ctldir.c

Linux 4.9 compat: fix zfs_ctldir xattr handling

2017-06-05 11:26:25 -07:00

zfs_debug.c

OpenZFS 7503 - zfs-test should tail ::zfs_dbgmsg on test failure

2017-04-12 13:36:48 -07:00

zfs_dir.c

Rename zfs_sb_t -> zfsvfs_t

2017-03-10 09:51:33 -08:00

zfs_fm.c

Fixed small memory leak in ereport handling

2017-05-18 17:35:49 -07:00

zfs_fuid.c

Rename zfs_sb_t -> zfsvfs_t

2017-03-10 09:51:33 -08:00

zfs_ioctl.c

OpenZFS 7600 - zfs rollback should pass target snapshot to kernel

2017-07-04 15:29:52 -07:00

zfs_log.c

OpenZFS 7578 - Fix/improve some aspects of ZIL writing

2017-06-09 09:15:37 -07:00

zfs_onexit.c

zfsdev_getminor() should check for invalid file handles

2015-06-22 17:02:13 -07:00

zfs_replay.c

Rename zfs_sb_t -> zfsvfs_t

2017-03-10 09:51:33 -08:00

zfs_rlock.c

Fix spelling

2017-01-03 11:31:18 -06:00

zfs_sa.c

Rename zfs_sb_t -> zfsvfs_t

2017-03-10 09:51:33 -08:00

zfs_vfsops.c

Linux 4.12 compat: fix super_setup_bdi_name() call

2017-05-25 09:55:55 -07:00

zfs_vnops.c

OpenZFS 8378 - crash due to bp in-memory modification of nopwrite block

2017-07-04 15:41:24 -07:00

zfs_znode.c

OpenZFS 8199 - multi-threaded dmu_object_alloc()

2017-06-09 09:43:26 -07:00

zil.c

OpenZFS 7578 - Fix/improve some aspects of ZIL writing

2017-06-09 09:15:37 -07:00

zio_checksum.c

Remove dependency on linear ABD

2017-03-29 12:24:51 -07:00

zio_compress.c

DLPX-44812 integrate EP-220 large memory scalability

2016-11-29 14:34:27 -08:00

zio_inject.c

Inject zinject(8) a percentage amount of dev errs

2017-06-16 17:21:11 -07:00

zio.c

OpenZFS 7578 - Fix/improve some aspects of ZIL writing

2017-06-09 09:15:37 -07:00

zle.c

Update core ZFS code from build 121 to build 141.

2010-05-28 13:45:14 -07:00

zpl_ctldir.c

Linux 4.12 compat: CURRENT_TIME removed

2017-05-10 09:30:48 -07:00

zpl_export.c

Use cstyle -cpP in make cstyle check

2016-12-12 10:46:26 -08:00

zpl_file.c

Rename zfs_sb_t -> zfsvfs_t

2017-03-10 09:51:33 -08:00

zpl_inode.c

Linux 4.12 compat: CURRENT_TIME removed

2017-05-10 09:30:48 -07:00

zpl_super.c

Restructure mount option handling

2017-03-10 09:51:41 -08:00

zpl_xattr.c

Linux 4.12 compat: CURRENT_TIME removed

2017-05-10 09:30:48 -07:00

zrlock.c

OpenZFS 3746 - ZRLs are racy

2017-01-23 10:35:58 -08:00

zvol.c

OpenZFS 8378 - crash due to bp in-memory modification of nopwrite block

2017-07-04 15:41:24 -07:00