freebsd with flexible iflib nic queues

Andriy Gapon 03ad5aa4c1 8569 problem with inline functions in abd.h ... illumos/illumos-gate@37e84ab74e 37e84ab74e https://www.illumos.org/issues/8569 C [C99] has peculiar rules for inline functions that are different from the C++ rules. Unlike C++ where inline is "fire and forget", in C a programmer must pay attention to the function's storage class / visibility. The main problem is with the case where a compiler decides to not inline a call to the function declared as inline. Some relevant links: - http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.faqs/ka15831.html - http://www.drdobbs.com/the-new-c-inline-functions/184401540 The summary is that either the inline functions should be declared 'static inline' or one of the compilation units (.c files) must provide a callable externally visible function definition. In the former case, the compiler would automatically create a local non-inlined function instance in every compilation unit where it's needed. In the latter case the single external definition is used to satisfy any non-inlined calls in all compilation units. As things stand right now, we can get an undefined reference error under certain combinations of compilers and compiler options. For example, this is what I get on FreeBSD when compiling with clang 4.0.0 and -O1: In function `abd_free': /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/abd.c:385: undefined reference to `abd_is_linear' So, there are two alternatives. Either to qualify each inline function in abd.h with static storage class. Or to add declarations like the following to abd.c: extern inline boolean_t abd_is_linear(abd_t *abd); Both work. I am not sure which one would be more consistent with the illumos development rules. Reviewed by: Matt Ahrens <mahrens@delphix.com> Approved by: Robert Mustacchi <rm@joyent.com> Author: Andriy Gapon <avg@FreeBSD.org>		2017-09-01 18:02:53 +00:00
cmd	8414 Implemented zpool scrub pause/resume	2017-09-01 17:43:08 +00:00
common	8021 ARC buf data scatter-ization	2017-05-26 12:13:27 +00:00
head	5066 remove support for non-ANSI compilation	2014-08-20 06:29:42 +00:00
lib	8414 Implemented zpool scrub pause/resume	2017-09-01 17:43:08 +00:00
man	8435 zpool.1m and zfs.1m: minor cleanup	2017-09-01 17:56:34 +00:00
tools/ctf	5589 improper use of NULL in tools/ctf	2015-03-09 20:43:14 +00:00
uts	8569 problem with inline functions in abd.h	2017-09-01 18:02:53 +00:00
OPENSOLARIS.LICENSE	Update vendor/opensolaris to last OpenSolaris state (13149:b23a4dab3d50)	2012-07-18 07:48:04 +00:00