freebsd-nq/module/zcommon
Matthew Ahrens 050d720c43 Remove dedupditto functionality
If dedup is in use, the `dedupditto` property can be set, causing ZFS to
keep an extra copy of data that is referenced many times (>100x).  The
idea was that this data is more important than other data and thus we
want to be really sure that it is not lost if the disk experiences a
small amount of random corruption.

ZFS (and system administrators) rely on the pool-level redundancy to
protect their data (e.g. mirroring or RAIDZ).  Since the user/sysadmin
doesn't have control over what data will be offered extra redundancy by
dedupditto, this extra redundancy is not very useful.  The bulk of the
data is still vulnerable to loss based on the pool-level redundancy.
For example, if particle strikes corrupt 0.1% of blocks, you will either
be saved by mirror/raidz, or you will be sad.  This is true even if
dedupditto saved another 0.01% of blocks from being corrupted.

Therefore, the dedupditto functionality is rarely enabled (i.e. the
property is rarely set), and it fulfills its promise of increased
redundancy even more rarely.

Additionally, this feature does not work as advertised (on existing
releases), because scrub/resilver did not repair the extra (dedupditto)
copy (see https://github.com/zfsonlinux/zfs/pull/8270).

In summary, this seldom-used feature doesn't work, and even if it did it
wouldn't provide useful data protection.  It has a non-trivial
maintenance burden (again see https://github.com/zfsonlinux/zfs/pull/8270).

We should remove the dedupditto functionality.  For backwards
compatibility with the existing CLI, "zpool set dedupditto" will still
"succeed" (exit code zero), but won't have any effect.  For backwards
compatibility with existing pools that had dedupditto enabled at some
point, the code will still be able to understand dedupditto blocks and
free them when appropriate.  However, ZFS won't write any new dedupditto
blocks.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Alek Pinchuk <apinchuk@datto.com>
Issue #8270 
Closes #8310
2019-06-19 14:54:02 -07:00
..
Makefile.in OpenZFS 7431 - ZFS Channel Programs 2018-02-08 15:28:18 -08:00
zfeature_common.c Implement Redacted Send/Receive 2019-06-19 09:48:12 -07:00
zfs_comutil.c OpenZFS 9337 - zfs get all is slow due to uncached metadata 2018-07-12 10:49:27 -07:00
zfs_deleg.c Update build system and packaging 2018-05-29 16:00:33 -07:00
zfs_fletcher_aarch64_neon.c Update build system and packaging 2018-05-29 16:00:33 -07:00
zfs_fletcher_avx512.c Update build system and packaging 2018-05-29 16:00:33 -07:00
zfs_fletcher_intel.c Update build system and packaging 2018-05-29 16:00:33 -07:00
zfs_fletcher_sse.c Update build system and packaging 2018-05-29 16:00:33 -07:00
zfs_fletcher_superscalar4.c Update build system and packaging 2018-05-29 16:00:33 -07:00
zfs_fletcher_superscalar.c Update build system and packaging 2018-05-29 16:00:33 -07:00
zfs_fletcher.c Update build system and packaging 2018-05-29 16:00:33 -07:00
zfs_namecheck.c Implement Redacted Send/Receive 2019-06-19 09:48:12 -07:00
zfs_prop.c Implement Redacted Send/Receive 2019-06-19 09:48:12 -07:00
zfs_uio.c Linux 5.0 compat: access_ok() drops 'type' parameter 2019-01-28 10:11:10 -08:00
zpool_prop.c Remove dedupditto functionality 2019-06-19 14:54:02 -07:00
zprop_common.c Fix 'zpool list -v' alignment 2018-12-04 10:17:54 -08:00